Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Treeselect in Site/Folder at Edit Content #28645

Closed
Tracked by #28494
nicobytes opened this issue May 23, 2024 · 2 comments · Fixed by #28700
Closed
Tracked by #28494

Use Treeselect in Site/Folder at Edit Content #28645

nicobytes opened this issue May 23, 2024 · 2 comments · Fixed by #28700
Assignees
@dsilvam
Labels
Merged QA : Approved Release : 24.06.21 Bug Fixing Team : Falcon Type : New Functionality

Comments

@nicobytes
Copy link
Contributor

nicobytes commented May 23, 2024 •
edited
Loading

Parent Issue

#28494

User Story

As a Content Architect in dotCMS, I want to add a Site/Folder field to the Edit Content Form so I can easily create and edit content.

Current behavior

The actual field uses the old design system and the idea is to implement the new TreeSelectComponent.

Screenshots

Original Updated
Screenshot 2024-05-24 at 5 07 07 PM Screenshot 2024-06-05 at 5 44 14 PM

Acceptance Criteria

  • When creating a SiteOrFolder field as part of the content type, the new TreeSelect component should be used.
  • If the content is new, the user should be able to navigate through the levels and select one.
  • Once saved, the user should be able to edit the field and the current tree should be expanded by default.

Proposed Objective

Component Integration, New Edit Content

Proposed Priority

Priority 2 - Important

dotCMS Version

master

External Links

Video Support

2024-06-05.17-38-53.mp4
@nicobytes nicobytes mentioned this issue May 23, 2024
Closed
@nicobytes nicobytes self-assigned this May 23, 2024
@nicobytes nicobytes linked a pull request May 30, 2024 that will close this issue
Use Treeselect in Site/Folder at Edit Content #28700
Merged
3 tasks
@nicobytes nicobytes mentioned this issue May 30, 2024
Merged
3 tasks
nicobytes added a commit that referenced this issue May 31, 2024
@nicobytes
chore(edit-content): creating init setup for unit test with the new s…
e06df39 
…ite /folder field #28645
nicobytes added a commit that referenced this issue Jun 5, 2024
@nicobytes
chore(edit-content): get current data and build current tree #28645
90af4d2
nicobytes added a commit that referenced this issue Jun 5, 2024
@nicobytes
chore(edit-content): get current data and build current tree #28645
f56b6dd
nicobytes added a commit that referenced this issue Jun 6, 2024
@nicobytes
chore(edit-content): avoid code smells #28645
78d08e4
nicobytes added a commit that referenced this issue Jun 6, 2024
@nicobytes
chore(edit-content): apply format #28645
17e473d
nicobytes added a commit that referenced this issue Jun 6, 2024
@nicobytes
chore(edit-content): sync with master and resolve conflicts #28645
2552dfc
nicobytes added a commit that referenced this issue Jun 6, 2024
@nicobytes
chore(edit-content): sync with master and resolve conflicts #28645
d4fd2f0
nicobytes added a commit that referenced this issue Jun 6, 2024
@nicobytes
chore(edit-content): apply format #28645
45bbbc7
nicobytes added a commit that referenced this issue Jun 6, 2024
@nicobytes
chore(edit-content): create unit tests #28645
c470369
nicobytes added a commit that referenced this issue Jun 6, 2024
@nicobytes
chore(edit-content): apply format #28645
f290a24
nicobytes added a commit that referenced this issue Jun 7, 2024
@nicobytes
chore(edit-content): unit test #28645
367bbc4
nicobytes added a commit that referenced this issue Jun 7, 2024
@nicobytes
chore(edit-content): add loading in nodes #28645
a9e75f1
nicobytes added a commit that referenced this issue Jun 7, 2024
@nicobytes
chore(edit-content): add loading in nodes #28645
f75b1a2
@dsilvam dsilvam removed the Triage label Jun 10, 2024
nicobytes added a commit that referenced this issue Jun 10, 2024
@nicobytes
chore(edit-content): fix conflicts and format #28645
81af59b
nicobytes added a commit that referenced this issue Jun 10, 2024
@nicobytes
chore(edit-content): resolve issues #28645
c6187aa
nicobytes added a commit that referenced this issue Jun 10, 2024
@nicobytes
chore(edit-content): add docs #28645
adabb3c
nicobytes added a commit that referenced this issue Jun 10, 2024
@nicobytes
chore(edit-content): fix error with types #28645
67d03dc
nicobytes added a commit that referenced this issue Jun 10, 2024
@nicobytes
chore(edit-content): use signals convention #28645
a755236
nicobytes added a commit that referenced this issue Jun 10, 2024
@nicobytes
chore(edit-content): fix error #28645
40d870f
nicobytes added a commit that referenced this issue Jun 10, 2024
@nicobytes
chore(edit-content): apply format #28645
b578f82
github-merge-queue bot pushed a commit that referenced this issue Jun 10, 2024
@nicobytes
Use Treeselect in Site/Folder at Edit Content (#28700)
faa8718 
### Issue

#28645

### Checklist
- [ ] Tests (WIP)
- [x] Translations
- [x] Security Implications Contemplated (add notes if applicable)

### User Story

As a Content Architect in dotCMS, I want to add a Site/Folder field to
the Edit Content Form so I can easily create and edit content.

### Current behavior

The actual field uses the old design system and the idea is to implement
the new TreeSelectComponent.

### Screenshots
Original             |  Updated
:-------------------------:|:-------------------------:
![Screenshot 2024-05-24 at 5 07
07 PM](https://github.com/dotCMS/core/assets/7611944/e82c1f6c-c20b-47d4-b8b9-4f2f2b55a613)
| ![Screenshot 2024-06-05 at 5 44
14 PM](https://github.com/dotCMS/core/assets/7611944/23556fe1-5e16-4b01-8c18-0c48876673c3)


### Acceptance Criteria

- When creating a SiteOrFolder field as part of the content type, the
new TreeSelect component should be used.
- If the content is new, the user should be able to navigate through the
levels and select one.
- Once saved, the user should be able to edit the field and the current
tree should be expanded by default.

### External Links
- PrimeNg TreeSelect documentation: [Link to PrimeNg
documentation](https://www.primefaces.org/primeng-v15-lts/treeselect)
- Design system specifications: [Link to design system
resources](https://www.figma.com/design/7CzbMcGSbTIJjerWtcapAm/Design-System-2023?node-id=896-21686&t=Tz8ZmnjBFv7ud8f4-4)

### Video Support


https://github.com/dotCMS/core/assets/7611944/f39e46f1-d9c0-4001-a7d2-1429ce2c72fa
@dsilvam dsilvam reopened this Jun 11, 2024
@dsilvam dsilvam self-assigned this Jun 17, 2024
@dsilvam
Copy link
Contributor

dsilvam commented Jun 17, 2024 •
edited
Loading

Passed Internal QA:
Tested with a very large number of sites/folders and working as expected.

Functionality tested:

  • Navigation/selection through the existing sites and folders.
  • Selecting/saving a Site.
  • Selecting/saving a Folder.
  • Opening a content with already saved Site - properly showing the saved Site on the component, but at the text-field level and at the Tree level.
  • Opening a content with already saved Folder - properly showing the saved Folder on the component, but at the text-field level and at the Tree level.

There's one detail found with the scroll bar indicator what was captured on a different card: #28843 (comment)

@dsilvam dsilvam closed this as completed Jun 17, 2024
@josemejias11
Copy link
Contributor

Approved: Tested on trunk_6d3ea16, Docker, macOS 14.5, FF v126.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsilvam dsilvam

Labels
Merged QA : Approved Release : 24.06.21 Bug Fixing Team : Falcon Type : New Functionality
Projects
dotCMS - Product Planning
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Treeselect in Site/Folder at Edit Content dotCMS/core
4 participants
@dsilvam @nicobytes @josemejias11 @freddyDOTCMS