Container Form #23110

motasimvd · 2022-10-06T13:10:01Z

Proposed Changes

Container Add
Container Update

Checklist

Tests
Translations
Security Implications Contemplated (add notes if applicable)

Additional Info

** any additional useful context or info **

Screenshots

Original	Updated
original screenshot	updated screenshot

github-actions · 2022-10-07T13:54:12Z

Unit Tests Report

1 332 tests 1 322 ✔️ 3m 1s ⏱️
  130 suites     10 💤
  130 files       0 ❌

Results for commit 8a3f6fa.

♻️ This comment has been updated with latest results.

alfredo-dotcms · 2022-10-07T14:58:41Z

core-web/apps/dotcms-ui/src/app/api/services/dot-containers/dot-containers.service.ts

@@ -70,16 +73,20 @@ export class DotContainersService {
     * @return Observable<DotContainer>


alfredo-dotcms · 2022-10-07T14:59:28Z

core-web/apps/dotcms-ui/src/app/api/services/dot-containers/dot-containers.service.ts

+            method: 'POST',
+            url: `${CONTAINER_API_URL}_add`,
+            body: values
+        });
    }

    /**
     * Updates a container
     * @returns Observable<DotContainer>


alfredo-dotcms · 2022-10-07T15:00:04Z

core-web/apps/dotcms-ui/src/app/api/services/dot-router/dot-router.service.ts

+    /**
+     * It navigates to the create container page
+     */
+    goToCreateContainer(): void {


alfredo-dotcms · 2022-10-07T15:03:55Z

...ntainers/dot-container-create/dot-container-properties/dot-container-properties.component.ts

+        }
+    }
+
+    updateContainerStructure(containerStructures: MenuItem[]) {


alfredo-dotcms · 2022-10-07T15:05:35Z

...ers/dot-container-create/dot-content-editor/dot-add-variable/dot-add-variable.component.html

+                        class="p-button-outlined p-button-secondary"
+                        (click)="onSave(variable?.variable)"
+                        pButton
+                        label="Add"


keyLanguage?

alfredo-dotcms · 2022-10-07T15:06:17Z

...iners/dot-container-create/dot-content-editor/dot-add-variable/dot-add-variable.component.ts

+@Component({
+    selector: 'dot-add-variable',
+    templateUrl: './dot-add-variable.component.html',
+    styleUrls: ['./dot-add-variable.component.scss'],


delete if it's not going to be used

alfredo-dotcms · 2022-10-07T15:06:46Z

...iners/dot-container-create/dot-content-editor/dot-add-variable/dot-add-variable.component.ts

+    /**
+     * Handle save button
+     *
+     * @memberof DotAddVariableComponent


alfredo-dotcms · 2022-10-07T15:11:02Z

...tlets/dot-containers/dot-container-create/dot-content-editor/dot-content-editor.component.ts

        }

        return false;
    }
+
+    updateContentTypeText(text: string) {


fix doc to all public methods

alfredo-dotcms · 2022-10-07T15:11:46Z

...tlets/dot-containers/dot-container-create/dot-content-editor/dot-content-editor.component.ts

+            width: '50rem',
+            data: {
+                contentTypeVariable: contentType.variable,
+                onSave: () =>


remove if not needed

alfredo-dotcms · 2022-10-07T15:13:23Z

...ms-ui/src/app/view/components/_common/dot-textarea-content/dot-textarea-content.component.ts

@@ -135,6 +138,9 @@ export class DotTextareaContentComponent implements OnInit, ControlValueAccessor
    onModelChange(value: string) {


… into feature/container-form

rjvelazco · 2022-10-20T04:29:59Z

I was doing Internal QA and found some unexpected behavior. I'm going to list them all here if any of this is expected behavior or isn't happening in your local environment please let me know.

When a save a container, I'm not getting redirected to the container list page.

unabled-to-save.mov

The search button, actions button, and show Archived checkbox are duplicated.

All the Mod. Dates are the same (53 years ago).

@fmontes I want to double-check this behavior.

redirect-or-check.mov

Also, @motasimvd, I was not able to update/edit a container, I'm always getting redirected to /containers/create route. Let me know if that is going to be in another PR.

…eature/container-form

zulqarnainvd · 2022-10-20T10:31:16Z

I was doing Internal QA and found some unexpected behavior. I'm going to list them all here if any of this is expected behavior or isn't happening in your local environment please let me know.

When a save a container, I'm not getting redirected to the container list page.

unabled-to-save.mov
2. The search button, actions button, and show Archived checkbox are duplicated.

All the Mod. Dates are the same (53 years ago).

@fmontes I want to double-check this behavior.

redirect-or-check.mov
Also, @motasimvd, I was not able to update/edit a container, I'm always getting redirected to /containers/create route. Let me know if that is going to be in another PR.

@rjvelazco Basically Edit endpoint work is not available in this branch It is available in the canary branch

…eature/container-form

fmontes · 2022-10-20T21:25:00Z

Not centered

“Description” should no be required, my mistake in the designs.

I don't think this div need it cuz' you're already have a nested wrapped.

Kapture.2022-10-20.at.14.56.32.mp4

Kapture.2022-10-20.at.15.00.02.mp4

Should be 500px height.

Use the .field class to separate the. label and the field, same for the post loop

Don't overwrite the component styles, leave as it is, if any change it should be global.

fmontes · 2022-10-20T22:42:29Z

.../apps/dotcms-ui/src/app/portlets/dot-containers/container-list/container-list.component.html

+            <dot-empty-state
+                [rows]="10"
+                [colsTextWidth]="[60, 50, 60, 80]"
+                [title]="'message.container.empty.title' | dm"
+                [content]="'message.container.empty.content' | dm"
+                [buttonLabel]="'message.container.empty.button.label' | dm"
+                (buttonClick)="handleEmptyStateButtonClick()"
+                icon="web"
+            ></dot-empty-state>


Do we need this now that we will never have an empty state?

fmontes · 2022-10-20T22:44:05Z

.../apps/dotcms-ui/src/app/portlets/dot-containers/container-list/container-list.component.html

+                <td [ngStyle]="{ 'text-align': tableColumns[3].textAlign }">
+                    {{ rowData.modDate }}
+                </td>
+                <td style="width: 5%; height: 3.85rem">


Why the height?

in progress

fmontes · 2022-10-20T22:45:16Z

.../apps/dotcms-ui/src/app/portlets/dot-containers/container-list/container-list.component.scss

+    .p-datatable .p-paginator-bottom {
+        border: none;
+    }


Can we do this globally? I think here: core-web/libs/dot-primeng-theme-styles/src/scss/dotcms-theme/components/_paginator.scss

fmontes · 2022-10-20T22:48:19Z

...eb/apps/dotcms-ui/src/app/portlets/dot-containers/container-list/container-list.component.ts

+     * @returns DotContainer[]
+     * @memberof DotContainerListComponent
+     */
+    mapTableItems(containers: DotContainer[]): DotContainer[] {


Suggested change

mapTableItems(containers: DotContainer[]): DotContainer[] {

getContainersWithDisabledEntities(containers: DotContainer[]): DotContainer[] {

fmontes · 2022-10-20T22:52:17Z

...eb/apps/dotcms-ui/src/app/portlets/dot-containers/container-list/container-list.component.ts

@@ -93,25 +95,44 @@ export class ContainerListComponent implements OnDestroy {
        return this.store.getContainerActions(container);
    }

+    /**
+     * Map table results to add the disableInteraction property.


Suggested change

* Map table results to add the disableInteraction property.

* Return a list of containers with disableInteraction in system items.

fmontes · 2022-10-20T23:41:30Z

...pp/portlets/dot-containers/dot-container-create/dot-loop-editor/dot-loop-editor.component.ts

@@ -7,6 +8,7 @@ import { Component, EventEmitter, Input, Output } from '@angular/core';
 })
 export class DotLoopEditorComponent {
    @Input() isEditorVisible = false;
+    @Input() control: FormControl;


The angular way: https://angular.io/api/forms/ControlValueAccessor

in progress

fmontes · 2022-10-21T00:26:48Z

.../app/portlets/dot-containers/dot-container-create/resolvers/dot-container-create.resolver.ts

 import { DotContainersService } from '@services/dot-containers/dot-containers.service';

 @Injectable()
-export class DotContainerCreateEditResolver implements Resolve<DotContainer> {
+export class DotContainerCreateEditResolver implements Resolve<DotContainerEntity> {


Suggested change

export class DotContainerCreateEditResolver implements Resolve<DotContainerEntity> {

export class DotContainerEditResolver implements Resolve<DotContainerEntity> {

fmontes · 2022-10-21T00:28:37Z

core-web/apps/dotcms-ui/src/app/shared/models/container/dot-container.model.ts

+    disableInteraction?: boolean;
+}
+
+export interface DotContainerRequest {


Suggested change

export interface DotContainerRequest {

export interface DotContainerPayload {

fmontes · 2022-10-21T00:31:08Z

...ms-ui/src/app/view/components/_common/dot-textarea-content/dot-textarea-content.component.ts

@@ -45,9 +45,18 @@ export class DotTextareaContentComponent implements OnInit, ControlValueAccessor
    @Input()
    width: string;

+    @Input()
+    hideBorder: boolean;


Suggested change

hideBorder: boolean;

customStyles: Record<string, unkown>

And that way you let this ready to be extendable instead of only remove borders.

fmontes · 2022-10-21T00:31:48Z

...ms-ui/src/app/view/components/_common/dot-textarea-content/dot-textarea-content.component.ts

+    hideBorder: boolean;
+
+    @Input()
+    editorName: string;


What happen if is not passed?

if it is not passed. It is showing undefined in Monaco Editor Initialization Object. this.monacoInit.emit({ name: this.editorName, editor });

fmontes

I'm merging this but still needs a lot of work, not only on functionality but in code and arquitecture.

* Create empty container portlet (#22783) * copy container rest endpoint added with curl tests (#22944) * copy container rest endpoint added with curl tests * Addressed MR comments * Addressed MR commentsby removing uuid validation as it is not needed * fixed by importing required code * Addressed PR comments by removing UUIDUtil import * Added Tabs to Container Create Page and updated language strings (#22932) * Added Tabs to Container Create Page and updated translation strings * Removed unused comment * Bulk delete container (#22973) * bulk delete rest endpoint * curl tests for bulk delete * more ids added for bulk delete operation * updated authorization user's password * Container bulk operations (#23012) * Container bulk publish/unpublish rest endpoints * Container bulk archive/unarchive rest endpoints * curl/postman tests for container bulk publish * curl/postman tests for all bulk operations * fixed failed test * Container permission and history iframes (#23025) * Added Container listing table and Filters (#22920) * [WIP] Added Container listing and filters to Container list page * [WIP] Refactor Container list to use already provided Container Interface * [WIP] Container status is now displayed correctly * [WIP] Updated unit tests and minor refactor * Fixed unit test and listing data table * Added template outlet before listing table search, Container list style and ui refactor * Added strings to Language file and updated string keys in Container List component * Added Component Store to Container Component * Modified container list component to better use selectors * moved activeRoue logic to store * Refactored ContainerList functionality to ContainerListStore * Method name refactor and State update minimisation * Fixed state initialization * Categories permissions iframe added (#23032) * code adjustments as per error handling standard (#23031) * Feature/container lisiting complete actions (#23030) * [WIP] Added Container listing and filters to Container list page * [WIP] Refactor Container list to use already provided Container Interface * [WIP] Container status is now displayed correctly * [WIP] Updated unit tests and minor refactor * Fixed unit test and listing data table * Added template outlet before listing table search, Container list style and ui refactor * Added strings to Language file and updated string keys in Container List component * [WIP] Added actions and Container service to handle actions * Updated unit tests * Added Component Store to Container Component * Modified container list component to better use selectors * moved activeRoue logic to store * Refactored ContainerList functionality to ContainerListStore * Method name refactor and State update minimisation * Fixed state initialization * [WIP] Added context menu actions and updated tests * Fixed Unit tests * Fixed Unit tests * Update core-web/apps/dotcms-ui/src/app/api/services/dot-router/dot-router.service.ts Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com> * Update core-web/apps/dotcms-ui/src/app/portlets/dot-containers/container-list/container-list.component.ts Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com> * Context menu actions hooked up to container service, Updated unit tests * Fixed store logic and fixed typos * Refactored container list component methods to container list store, Fixed typos, Updated container routes Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com> * Category rest endpoints for Add category, Update category and get children categories (#23029) * Add category rest endpoint * curl test fix * rest endpoint added to get children categories by parent inode * curl/postman tests * addressed PR comments and also renamed API from children to _children * reverted API name from _children to children * Updated API documentation * Code changes as per suggestions from code reviewing team * removed unnecessary imports * Update category rest endpoint added * little changes * fix for the curl test * Delete category rest endpoint (#23080) * Delete category rest endpoint * addressed feedback from BE team * Feature/container properties form (#23020) * Added Tabs to Container Create Page and updated translation strings * Added container properties component and added Inplace editor to it * Removed unused comment * [WIP] Properties form UI updated * Added Monaco Editor to Properties Form * add history and permission iframe * refactoring * create edit route for container and resolver * Added controls to container form * change component and folders name * Added method docs, Added translations, Minor fixes * Added missing translations * Added MonacoEditor type model for reusability * CSS refactor * CSS refactor * Renamed container create component as DotContainerCreateComponent * Component and SCSS refactor * Refactored Loop editor to new component * Update core-web/apps/dotcms-ui/src/app/portlets/dot-containers/dot-container-create/dot-container-history/dot-container-history.component.ts Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com> * Update core-web/apps/dotcms-ui/src/app/portlets/dot-containers/dot-container-create/dot-container-permissions/dot-container-permissions.component.ts Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com> * Refactored Content Editor to new component * Fixed Permissions and History componanets * change css style and remove unnecessary ng deep * change css style and remove unnecessary ng deep * Update core-web/apps/dotcms-ui/src/app/portlets/dot-containers/dot-container-create/dot-container-create.component.scss Co-authored-by: Freddy Montes <freddymontes@gmail.com> * Update core-web/apps/dotcms-ui/src/app/portlets/dot-containers/dot-container-create/dot-content-editor/store/dot-content-editor.store.ts Co-authored-by: Freddy Montes <freddymontes@gmail.com> * Removed unnecessary monaco editor initializations * fixed box height issue Co-authored-by: Zulqarnain Huda <zulqarnain.huda@venturedive.com> Co-authored-by: zulqarnainvd <113915849+zulqarnainvd@users.noreply.github.com> Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com> Co-authored-by: Freddy Montes <freddymontes@gmail.com> * Rest endpoint to update categories for sortOrder (#23091) * Rest endpoint to update categories for sortOrder * updated credentials * Addressed PR feedback * add permissions and history tab and load Iframe in Tabs (#23092) * add permissions and history tab and load Iframe in Tabs * write test cases using host component method and use variable in scss * Export categories rest endpoint (#23108) * Export categories rest endpoint * addressed PR feedback * Add/Get container details (#23126) * improvements in old code * add container rest endpoint added * Container details endpoint added to fetch container + structures info combinely * curl test + improvements * addressed PR feedback for _add rest endpoint * removed details endpoint and added support in the live and working endpoint to fetch contentTypes * code cleanup * Import categories rest endpoint (#23125) * Import categories rest endpoint * addressed PR feedback on categories import * addressed further feedback on categories import * Addressed PR feedback * converted categoryDTO to immutable * container rest endpoint modified to accept container code changes (#23157) * container rest endpoint modified to accept container code changes * curl/postman test added * Curl test fix (#23161) * changed admin user's password * fixed curl test * updated tests assertions * removed obsolete code/classes for categories (#23168) * removed obsolete code/classes for categories * Removed useless entries * removed servlet-mapping from web.xml * Feature/categories permissions (#23047) * categories initialization * fix unit test of category component * add Category Table and actions * add sub category beadcrumb and update sub category in table * modify subCategoryUrl and fix typo in table * add permission component and create a store * change folder name and css class convention * add docs and refactor the code * add doc * disable home button * changing code according to suggestions and write unit test of categorly listing component * add action header and Table UI of categories * add pagination and search filter * feat: working on categories * feat: working on categories * add pagination and search filter * refactoring and change doc * otCMS/core#23253 Categories: Fix the sort order in the endpoint * Revert "removed obsolete code/classes for categories (#23168)" (#23288) This reverts commit 2762511. * Container Form (#23110) * Added Simple form to container properties * add confirmation dialog on clear * Container can now be added using the simple form * fix create container route issue and get data in container properties * Added inplace data variable and fixed inplace CSS * Form is now editable * add Variable popup model * Added form validation and disabled button on zero max contentlets * Load content type from different source * add content type to menu state * get contentStructure value from child component to parent * Variable modal now works * Fixes to container add code * Addressed Feedback * Addressed Feedback * set variable in editor * Added update logic, Fixed failing unit tests * Fixed faorm initilisation issue * Addressed Feedback * changes according to PR * Fixed notification issue in container list * Fixed container list empty messages and linked butoon to create container * changes according to new API and requested PR changes * changes according to PR and working fedback UI 3 issues * Container Add form CSS Fixes * Added label and CSS fixes * Fixed clear button * Title field now enabled on container Add form * disable save button when required fields is empty or on edit value is not changed * #23144 Added API Link Component, Fixed button text * fix UI issues * fix UI issues and test cases * refactor code * Fixed CSS, Updated url to load system containers * Disabled interaction in container list for System Container * Updated tests * fix contentType Variable issue and container listing scroll issue * Removed optional identifier from container Request * fix reported issues * Removed from container properties template * refactoring and change name of resolver * PR requested changes * remove validation of description field * Conatiner Properties Form UI Fixes * Implemented Control Value Accessor for DotLoopEditor Component * Code impovements and fixes * #23146 Refactored Content Editor component into a angular form control * #23146 [WIP] Adding data to form control * Rename code component Co-authored-by: Zulqarnain Huda <zulqarnain.huda@venturedive.com> Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com> * get categories childrens and add breadcrumb (#23260) * get categories childrens and add breadcrumb * refactor: changes according to PR * refactor: add unit test case of category listing component * #23252 working on categories feedbacks and write test cases * #23252 working on categories feedbacks and write test cases * Fix tests build for containers * Clean up model * Clean up renamed container * #23252 fix category filter issue (#23308) * Added children count in the top level categories list (#23263) * Added children count in the top level categories list * added categories paginator for additional information * Addressed PR feedback * added line space at line number 94 * added java doc on the CategoryResource API + added postman tests * Fix import Co-authored-by: Daniel Silva <daniel.silva@dotcms.com> Co-authored-by: hassan-mustafa-baig <111717530+hassan-mustafa-baig@users.noreply.github.com> Co-authored-by: motasimvd <62100713+motasimvd@users.noreply.github.com> Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com> Co-authored-by: Zulqarnain Huda <zulqarnain.huda@venturedive.com> Co-authored-by: zulqarnainvd <113915849+zulqarnainvd@users.noreply.github.com>

motasimvd and others added 13 commits October 5, 2022 19:11

Added Simple form to container properties

6c0c02c

add confirmation dialog on clear

2af2fcb

Container can now be added using the simple form

70b651f

Merge branch 'canary' into feature/container-form

2369832

fix create container route issue and get data in container properties

29ab159

Added inplace data variable and fixed inplace CSS

1a06127

Form is now editable

0244700

add Variable popup model

809500c

Added form validation and disabled button on zero max contentlets

7d869c4

Load content type from different source

06ff923

add content type to menu state

6ab65ec

get contentStructure value from child component to parent

0e5e95b

Variable modal now works

867481c

Fixes to container add code

6f43876

motasimvd marked this pull request as ready for review October 7, 2022 14:26

motasimvd requested a review from fmontes October 7, 2022 14:26

fmontes requested review from rjvelazco, alfredo-dotcms and hmoreras October 7, 2022 14:54

alfredo-dotcms reviewed Oct 7, 2022

View reviewed changes

motasimvd requested a review from hmoreras October 19, 2022 08:08

motasimvd and others added 4 commits October 19, 2022 15:47

Disabled interaction in container list for System Container

d5f6350

Updated tests

ef741d4

fix contentType Variable issue and container listing scroll issue

d0c12c3

Merge branch 'feature/container-form' of https://github.com/dotCMS/core…

8b082e6

… into feature/container-form

motasimvd mentioned this pull request Oct 19, 2022

Containers: UI feedback 1 #23141

Closed

5 tasks

motasimvd added 2 commits October 20, 2022 13:41

Removed optional identifier from container Request

5f47c18

Merge remote-tracking branch 'upstream/feature/container-form' into f…

a39d8c6

…eature/container-form

zulqarnainvd and others added 3 commits October 20, 2022 16:55

fix reported issues

0544c6b

Removed from container properties template

d2e1bc7

Merge remote-tracking branch 'upstream/feature/container-form' into f…

744bc90

…eature/container-form

fmontes requested changes Oct 21, 2022

View reviewed changes

zulqarnainvd and others added 9 commits October 21, 2022 13:53

refactoring and change name of resolver

b20c5a8

PR requested changes

3500fe4

remove validation of description field

8ac4150

Conatiner Properties Form UI Fixes

fc5ee86

Implemented Control Value Accessor for DotLoopEditor Component

8fadc27

Code impovements and fixes

8a3f6fa

#23146 Refactored Content Editor component into a angular form control

097b14a

#23146 [WIP] Adding data to form control

f242617

Rename code component

35bbf1f

fmontes reviewed Nov 3, 2022

View reviewed changes

Merge branch 'canary' into feature/container-form

5e878aa

fmontes merged commit 81b2d59 into canary Nov 3, 2022

fmontes deleted the feature/container-form branch November 3, 2022 01:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Container Form #23110

Container Form #23110

motasimvd commented Oct 6, 2022

github-actions bot commented Oct 7, 2022 •

edited

alfredo-dotcms Oct 7, 2022

alfredo-dotcms Oct 7, 2022

alfredo-dotcms Oct 7, 2022

alfredo-dotcms Oct 7, 2022

alfredo-dotcms Oct 7, 2022

alfredo-dotcms Oct 7, 2022

alfredo-dotcms Oct 7, 2022

alfredo-dotcms Oct 7, 2022

alfredo-dotcms Oct 7, 2022

motasimvd Oct 7, 2022

alfredo-dotcms Oct 7, 2022

rjvelazco commented Oct 20, 2022 •

edited

zulqarnainvd commented Oct 20, 2022

fmontes commented Oct 20, 2022 •

edited

fmontes Oct 20, 2022

fmontes Oct 20, 2022

motasimvd Oct 24, 2022

fmontes Oct 20, 2022

fmontes Oct 20, 2022

fmontes Oct 20, 2022

fmontes Oct 20, 2022

motasimvd Oct 24, 2022

fmontes Oct 21, 2022

fmontes Oct 21, 2022

fmontes Oct 21, 2022

fmontes Oct 21, 2022

zulqarnainvd Oct 21, 2022

fmontes left a comment

		@@ -70,16 +73,20 @@ export class DotContainersService {
		* @return Observable<DotContainer>

		@@ -135,6 +138,9 @@ export class DotTextareaContentComponent implements OnInit, ControlValueAccessor
		onModelChange(value: string) {

	mapTableItems(containers: DotContainer[]): DotContainer[] {
	getContainersWithDisabledEntities(containers: DotContainer[]): DotContainer[] {

	* Map table results to add the disableInteraction property.
	* Return a list of containers with disableInteraction in system items.

	export class DotContainerCreateEditResolver implements Resolve<DotContainerEntity> {
	export class DotContainerEditResolver implements Resolve<DotContainerEntity> {

	export interface DotContainerRequest {
	export interface DotContainerPayload {

Container Form #23110

Container Form #23110

Conversation

motasimvd commented Oct 6, 2022

Proposed Changes

Checklist

Additional Info

Screenshots

github-actions bot commented Oct 7, 2022 • edited

Unit Tests Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rjvelazco commented Oct 20, 2022 • edited

zulqarnainvd commented Oct 20, 2022

fmontes commented Oct 20, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fmontes left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 7, 2022 •

edited

rjvelazco commented Oct 20, 2022 •

edited

fmontes commented Oct 20, 2022 •

edited