Feature/container properties form #23020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmontes
requested changes
Sep 20, 2022
Comment on lines
4
to
30
| .dot-container-properties__title-container { | ||
| padding: $spacing-4 0; | ||
| } | ||
|
|
||
| .dot-container-properties__code-container-outer { | ||
| background: $white; | ||
| display: flex; | ||
| height: 100%; | ||
| flex-direction: column; | ||
|
|
||
| .dot-container-properties__pre-post-loop { | ||
| .dot-container-properties__pre-post-loop-inplace { | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| padding: $spacing-6; | ||
| background: #e9ebfc; | ||
| } | ||
| } | ||
|
|
||
| form { | ||
| margin: $spacing-3; | ||
| height: 100%; | ||
| display: flex; | ||
| flex-direction: column; | ||
| } | ||
| } |
There was a problem hiding this comment.
With BEM you don't need all the nesting.
fmontes
requested changes
Sep 26, 2022
| flex-direction: column; | ||
| overflow: auto; | ||
|
|
||
| .container-create__tabs { |
There was a problem hiding this comment.
You don't need this nesting here.
| @@ -0,0 +1,22 @@ | |||
| import { Component, OnChanges, OnInit, ViewChild } from '@angular/core'; | |||
There was a problem hiding this comment.
FYI I'm getting 404 in both, not sure why.
There was a problem hiding this comment.
BE changes not merged in this branch
| @@ -0,0 +1,4 @@ | |||
| dot-portlet-box { | |||
| height: 100vh; | |||
| overflow: hidden; | |||
There was a problem hiding this comment.
It is because we need 100% height of the box and hides the unnecessary scrollbar before content.
There was a problem hiding this comment.
But there are vertical space from the top bar and the padding that I think is not being take into consideration here.
Comment on lines
8
to
15
| .dot-container-properties__code-container-outer { | ||
| background: $white; | ||
| display: flex; | ||
| height: 100%; | ||
| flex-direction: column; | ||
|
|
||
| .dot-container-properties__pre-post-loop { | ||
| .dot-container-properties__pre-post-loop-inplace { |
There was a problem hiding this comment.
Don't need all this nesting, BEM does it implicitly
...t-containers/container-create/dot-container-properties/dot-container-properties.component.ts
Outdated
Show resolved
Hide resolved
Comment on lines
47
to
51
| showLoopInput(): void { | ||
| this.store.updatePrePostLoopInputVisibility(true); | ||
| } | ||
|
|
||
| handleChange(e): boolean { |
...containers/container-create/dot-container-properties/store/dot-container-properties.store.ts
Outdated
Show resolved
Hide resolved
...pp/portlets/dot-containers/container-create/resolvers/dot-container-create-.resolver.spec.ts
Outdated
Show resolved
Hide resolved
.../src/app/portlets/dot-containers/container-create/resolvers/dot-container-create.resolver.ts
Outdated
Show resolved
Hide resolved
| templateUrl: './container-history.component.html', | ||
| styleUrls: ['./container-history.component.scss'] | ||
| }) | ||
| export class ContainerHistoryComponent implements OnInit, OnChanges { |
There was a problem hiding this comment.
you're missing the "Dot-" prefix also
#23018 (comment)
please check that on all Container files
| ></button> | ||
| </div> | ||
| <div *ngIf="vm.showPrePostLoopInput"> | ||
| <label>Pre-loop</label> |
| pButton | ||
| class="p-button-outlined p-button-secondary" | ||
| type="button" | ||
| label="ADD PRE AND POST LOOP CODE" |
| </div> | ||
| </div> | ||
| <div class="dot-container-properties__content-tab-container"> | ||
| <label>Content Type and Code</label> |
| ></button> | ||
| </div> | ||
| <div *ngIf="vm.showPrePostLoopInput"> | ||
| <label>Post-loop</label> |
| this.editor = editor; | ||
| } | ||
|
|
||
| showLoopInput(): void { |
| </span> | ||
| </ng-template> | ||
| <ng-template pTemplate="display"> | ||
| Click to Edit |
| </p-inplace> | ||
| </div> | ||
| <div class="field"> | ||
| <label for="description" class="block">Description</label> |
| <input id="description" type="text" pInputText /> | ||
| </div> | ||
| <div class="field"> | ||
| <label for="max-contents" class="block">Max Contents</label> |
motasimvd
requested review from
fmontes and
alfredo-dotcms
and removed request for
fmontes and
alfredo-dotcms
rjvelazco
requested changes
Sep 29, 2022
| @@ -0,0 +1,119 @@ | |||
| /* eslint-disable @typescript-eslint/no-explicit-any */ | |||
There was a problem hiding this comment.
Do we need to disable this rule? Just in case, if you need any type of a component/response, let us know.
fmontes
requested changes
Sep 29, 2022
| @@ -0,0 +1,4 @@ | |||
| dot-portlet-box { | |||
| height: 100vh; | |||
There was a problem hiding this comment.
Don't we have some padding and header that could break with this?
| @use "variables" as *; | ||
|
|
||
| :host ::ng-deep { | ||
| .dot-container-properties__title-container { |
There was a problem hiding this comment.
This is not need it in the ::ng-deep because this not need to be outside the angular encap, check the other components as well.
You only need the ::ng-deep when accessing primeng components.
| formControlName="body" | ||
| [show]="['code']" | ||
| language="html" | ||
| (monacoInit)="initEditor($event)" |
There was a problem hiding this comment.
Isn't a problem that we are init the 3 monaco editors in the same class prop?
Comment on lines
33
to
35
| initEditor(editor: MonacoEditor): void { | ||
| this.editor = editor; | ||
| } |
|
|
||
| const contentTypes$ = this.dotContentTypeService.getAllContentTypes(); | ||
|
|
||
| zip(contentTypes$) |
alfredo-dotcms
approved these changes
Sep 29, 2022
…ntainer-create/dot-container-history/dot-container-history.component.ts Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com>
…ntainer-create/dot-container-permissions/dot-container-permissions.component.ts Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com>
…m' into feature/container-properties-form
fmontes
reviewed
Oct 3, 2022
| @use "variables" as *; | ||
|
|
||
| :host ::ng-deep { | ||
| .dot-container-properties__title-container { |
Comment on lines
3
to
26
| :host ::ng-deep { | ||
| .container-create__tab-container { | ||
| display: flex; | ||
| flex-direction: column; | ||
| overflow: auto; | ||
| } | ||
|
|
||
| .container-create__tabs { | ||
| .p-tabview-panels { | ||
| overflow: hidden; | ||
| flex-grow: 1; | ||
| flex-basis: 0; | ||
| } | ||
| .p-tabview-nav { | ||
| padding: 0 $spacing-4; | ||
| background: $white; | ||
| } | ||
|
|
||
| .p-tabview-panel { | ||
| padding: 0 $spacing-4; | ||
| padding-top: $spacing-4; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| :host ::ng-deep { | |
| .container-create__tab-container { | |
| display: flex; | |
| flex-direction: column; | |
| overflow: auto; | |
| } | |
| .container-create__tabs { | |
| .p-tabview-panels { | |
| overflow: hidden; | |
| flex-grow: 1; | |
| flex-basis: 0; | |
| } | |
| .p-tabview-nav { | |
| padding: 0 $spacing-4; | |
| background: $white; | |
| } | |
| .p-tabview-panel { | |
| padding: 0 $spacing-4; | |
| padding-top: $spacing-4; | |
| } | |
| } | |
| } | |
| .container-create__tab-container { | |
| display: flex; | |
| flex-direction: column; | |
| overflow: auto; | |
| } | |
| .container-create__tabs ::ng-deep { | |
| .p-tabview-panels { | |
| overflow: hidden; | |
| flex-grow: 1; | |
| flex-basis: 0; | |
| } | |
| .p-tabview-nav { | |
| padding: 0 $spacing-4; | |
| background: $white; | |
| } | |
| .p-tabview-panel { | |
| padding: 0 $spacing-4; | |
| padding-top: $spacing-4; | |
| } | |
| } |
| @@ -0,0 +1,4 @@ | |||
| dot-portlet-box { | |||
| height: 100vh; | |||
| overflow: hidden; | |||
There was a problem hiding this comment.
But there are vertical space from the top bar and the padding that I think is not being take into consideration here.
fmontes
requested changes
Oct 3, 2022
| @use "variables" as *; | ||
|
|
||
| :host ::ng-deep { | ||
| .dot-container-properties__title-container { |
fmontes
requested changes
Oct 3, 2022
| @@ -0,0 +1,4 @@ | |||
| dot-portlet-box { | |||
| height: 70vh; | |||
There was a problem hiding this comment.
This is not responsive... we don't know if the rest of the elements of the page will be 30vh.
| @@ -0,0 +1,4 @@ | |||
| dot-portlet-box { | |||
| height: 70vh; | |||
There was a problem hiding this comment.
This is not responsive... we don't know if the rest of the elements of the page will be 30vh.
...-ui/src/app/portlets/dot-containers/dot-container-create/dot-container-create.component.scss
Outdated
Show resolved
Hide resolved
| * @memberof DotContentEditorComponent | ||
| */ | ||
| initEditor(editor: MonacoEditor): void { | ||
| this.editor = editor; |
...ets/dot-containers/dot-container-create/dot-content-editor/store/dot-content-editor.store.ts
Outdated
Show resolved
Hide resolved
| * @memberof DotLoopEditorComponent | ||
| */ | ||
| initEditor(editor: MonacoEditor): void { | ||
| this.editor = editor; |
…ntainer-create/dot-container-create.component.scss Co-authored-by: Freddy Montes <freddymontes@gmail.com>
…ntainer-create/dot-content-editor/store/dot-content-editor.store.ts Co-authored-by: Freddy Montes <freddymontes@gmail.com>
fmontes
reviewed
Oct 4, 2022
|
|
||
| & ::ng-deep { | ||
| .tab-panel-btn { | ||
| background: #1b3359; |
There was a problem hiding this comment.
Suggested change
| background: #1b3359; | |
| background: $brand-background; |
fmontes
approved these changes
Oct 4, 2022
fmontes
added a commit
that referenced
this pull request
Nov 7, 2022
* Create empty container portlet (#22783) * copy container rest endpoint added with curl tests (#22944) * copy container rest endpoint added with curl tests * Addressed MR comments * Addressed MR commentsby removing uuid validation as it is not needed * fixed by importing required code * Addressed PR comments by removing UUIDUtil import * Added Tabs to Container Create Page and updated language strings (#22932) * Added Tabs to Container Create Page and updated translation strings * Removed unused comment * Bulk delete container (#22973) * bulk delete rest endpoint * curl tests for bulk delete * more ids added for bulk delete operation * updated authorization user's password * Container bulk operations (#23012) * Container bulk publish/unpublish rest endpoints * Container bulk archive/unarchive rest endpoints * curl/postman tests for container bulk publish * curl/postman tests for all bulk operations * fixed failed test * Container permission and history iframes (#23025) * Added Container listing table and Filters (#22920) * [WIP] Added Container listing and filters to Container list page * [WIP] Refactor Container list to use already provided Container Interface * [WIP] Container status is now displayed correctly * [WIP] Updated unit tests and minor refactor * Fixed unit test and listing data table * Added template outlet before listing table search, Container list style and ui refactor * Added strings to Language file and updated string keys in Container List component * Added Component Store to Container Component * Modified container list component to better use selectors * moved activeRoue logic to store * Refactored ContainerList functionality to ContainerListStore * Method name refactor and State update minimisation * Fixed state initialization * Categories permissions iframe added (#23032) * code adjustments as per error handling standard (#23031) * Feature/container lisiting complete actions (#23030) * [WIP] Added Container listing and filters to Container list page * [WIP] Refactor Container list to use already provided Container Interface * [WIP] Container status is now displayed correctly * [WIP] Updated unit tests and minor refactor * Fixed unit test and listing data table * Added template outlet before listing table search, Container list style and ui refactor * Added strings to Language file and updated string keys in Container List component * [WIP] Added actions and Container service to handle actions * Updated unit tests * Added Component Store to Container Component * Modified container list component to better use selectors * moved activeRoue logic to store * Refactored ContainerList functionality to ContainerListStore * Method name refactor and State update minimisation * Fixed state initialization * [WIP] Added context menu actions and updated tests * Fixed Unit tests * Fixed Unit tests * Update core-web/apps/dotcms-ui/src/app/api/services/dot-router/dot-router.service.ts Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com> * Update core-web/apps/dotcms-ui/src/app/portlets/dot-containers/container-list/container-list.component.ts Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com> * Context menu actions hooked up to container service, Updated unit tests * Fixed store logic and fixed typos * Refactored container list component methods to container list store, Fixed typos, Updated container routes Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com> * Category rest endpoints for Add category, Update category and get children categories (#23029) * Add category rest endpoint * curl test fix * rest endpoint added to get children categories by parent inode * curl/postman tests * addressed PR comments and also renamed API from children to _children * reverted API name from _children to children * Updated API documentation * Code changes as per suggestions from code reviewing team * removed unnecessary imports * Update category rest endpoint added * little changes * fix for the curl test * Delete category rest endpoint (#23080) * Delete category rest endpoint * addressed feedback from BE team * Feature/container properties form (#23020) * Added Tabs to Container Create Page and updated translation strings * Added container properties component and added Inplace editor to it * Removed unused comment * [WIP] Properties form UI updated * Added Monaco Editor to Properties Form * add history and permission iframe * refactoring * create edit route for container and resolver * Added controls to container form * change component and folders name * Added method docs, Added translations, Minor fixes * Added missing translations * Added MonacoEditor type model for reusability * CSS refactor * CSS refactor * Renamed container create component as DotContainerCreateComponent * Component and SCSS refactor * Refactored Loop editor to new component * Update core-web/apps/dotcms-ui/src/app/portlets/dot-containers/dot-container-create/dot-container-history/dot-container-history.component.ts Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com> * Update core-web/apps/dotcms-ui/src/app/portlets/dot-containers/dot-container-create/dot-container-permissions/dot-container-permissions.component.ts Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com> * Refactored Content Editor to new component * Fixed Permissions and History componanets * change css style and remove unnecessary ng deep * change css style and remove unnecessary ng deep * Update core-web/apps/dotcms-ui/src/app/portlets/dot-containers/dot-container-create/dot-container-create.component.scss Co-authored-by: Freddy Montes <freddymontes@gmail.com> * Update core-web/apps/dotcms-ui/src/app/portlets/dot-containers/dot-container-create/dot-content-editor/store/dot-content-editor.store.ts Co-authored-by: Freddy Montes <freddymontes@gmail.com> * Removed unnecessary monaco editor initializations * fixed box height issue Co-authored-by: Zulqarnain Huda <zulqarnain.huda@venturedive.com> Co-authored-by: zulqarnainvd <113915849+zulqarnainvd@users.noreply.github.com> Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com> Co-authored-by: Freddy Montes <freddymontes@gmail.com> * Rest endpoint to update categories for sortOrder (#23091) * Rest endpoint to update categories for sortOrder * updated credentials * Addressed PR feedback * add permissions and history tab and load Iframe in Tabs (#23092) * add permissions and history tab and load Iframe in Tabs * write test cases using host component method and use variable in scss * Export categories rest endpoint (#23108) * Export categories rest endpoint * addressed PR feedback * Add/Get container details (#23126) * improvements in old code * add container rest endpoint added * Container details endpoint added to fetch container + structures info combinely * curl test + improvements * addressed PR feedback for _add rest endpoint * removed details endpoint and added support in the live and working endpoint to fetch contentTypes * code cleanup * Import categories rest endpoint (#23125) * Import categories rest endpoint * addressed PR feedback on categories import * addressed further feedback on categories import * Addressed PR feedback * converted categoryDTO to immutable * container rest endpoint modified to accept container code changes (#23157) * container rest endpoint modified to accept container code changes * curl/postman test added * Curl test fix (#23161) * changed admin user's password * fixed curl test * updated tests assertions * removed obsolete code/classes for categories (#23168) * removed obsolete code/classes for categories * Removed useless entries * removed servlet-mapping from web.xml * Feature/categories permissions (#23047) * categories initialization * fix unit test of category component * add Category Table and actions * add sub category beadcrumb and update sub category in table * modify subCategoryUrl and fix typo in table * add permission component and create a store * change folder name and css class convention * add docs and refactor the code * add doc * disable home button * changing code according to suggestions and write unit test of categorly listing component * add action header and Table UI of categories * add pagination and search filter * feat: working on categories * feat: working on categories * add pagination and search filter * refactoring and change doc * otCMS/core#23253 Categories: Fix the sort order in the endpoint * Revert "removed obsolete code/classes for categories (#23168)" (#23288) This reverts commit 2762511. * Container Form (#23110) * Added Simple form to container properties * add confirmation dialog on clear * Container can now be added using the simple form * fix create container route issue and get data in container properties * Added inplace data variable and fixed inplace CSS * Form is now editable * add Variable popup model * Added form validation and disabled button on zero max contentlets * Load content type from different source * add content type to menu state * get contentStructure value from child component to parent * Variable modal now works * Fixes to container add code * Addressed Feedback * Addressed Feedback * set variable in editor * Added update logic, Fixed failing unit tests * Fixed faorm initilisation issue * Addressed Feedback * changes according to PR * Fixed notification issue in container list * Fixed container list empty messages and linked butoon to create container * changes according to new API and requested PR changes * changes according to PR and working fedback UI 3 issues * Container Add form CSS Fixes * Added label and CSS fixes * Fixed clear button * Title field now enabled on container Add form * disable save button when required fields is empty or on edit value is not changed * #23144 Added API Link Component, Fixed button text * fix UI issues * fix UI issues and test cases * refactor code * Fixed CSS, Updated url to load system containers * Disabled interaction in container list for System Container * Updated tests * fix contentType Variable issue and container listing scroll issue * Removed optional identifier from container Request * fix reported issues * Removed from container properties template * refactoring and change name of resolver * PR requested changes * remove validation of description field * Conatiner Properties Form UI Fixes * Implemented Control Value Accessor for DotLoopEditor Component * Code impovements and fixes * #23146 Refactored Content Editor component into a angular form control * #23146 [WIP] Adding data to form control * Rename code component Co-authored-by: Zulqarnain Huda <zulqarnain.huda@venturedive.com> Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com> * get categories childrens and add breadcrumb (#23260) * get categories childrens and add breadcrumb * refactor: changes according to PR * refactor: add unit test case of category listing component * #23252 working on categories feedbacks and write test cases * #23252 working on categories feedbacks and write test cases * Fix tests build for containers * Clean up model * Clean up renamed container * #23252 fix category filter issue (#23308) * Added children count in the top level categories list (#23263) * Added children count in the top level categories list * added categories paginator for additional information * Addressed PR feedback * added line space at line number 94 * added java doc on the CategoryResource API + added postman tests * Fix import Co-authored-by: Daniel Silva <daniel.silva@dotcms.com> Co-authored-by: hassan-mustafa-baig <111717530+hassan-mustafa-baig@users.noreply.github.com> Co-authored-by: motasimvd <62100713+motasimvd@users.noreply.github.com> Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com> Co-authored-by: Zulqarnain Huda <zulqarnain.huda@venturedive.com> Co-authored-by: zulqarnainvd <113915849+zulqarnainvd@users.noreply.github.com>
jcastro-dotcms
pushed a commit
that referenced
this pull request
Nov 14, 2022
* Create empty container portlet (#22783) * copy container rest endpoint added with curl tests (#22944) * copy container rest endpoint added with curl tests * Addressed MR comments * Addressed MR commentsby removing uuid validation as it is not needed * fixed by importing required code * Addressed PR comments by removing UUIDUtil import * Added Tabs to Container Create Page and updated language strings (#22932) * Added Tabs to Container Create Page and updated translation strings * Removed unused comment * Bulk delete container (#22973) * bulk delete rest endpoint * curl tests for bulk delete * more ids added for bulk delete operation * updated authorization user's password * Container bulk operations (#23012) * Container bulk publish/unpublish rest endpoints * Container bulk archive/unarchive rest endpoints * curl/postman tests for container bulk publish * curl/postman tests for all bulk operations * fixed failed test * Container permission and history iframes (#23025) * Added Container listing table and Filters (#22920) * [WIP] Added Container listing and filters to Container list page * [WIP] Refactor Container list to use already provided Container Interface * [WIP] Container status is now displayed correctly * [WIP] Updated unit tests and minor refactor * Fixed unit test and listing data table * Added template outlet before listing table search, Container list style and ui refactor * Added strings to Language file and updated string keys in Container List component * Added Component Store to Container Component * Modified container list component to better use selectors * moved activeRoue logic to store * Refactored ContainerList functionality to ContainerListStore * Method name refactor and State update minimisation * Fixed state initialization * Categories permissions iframe added (#23032) * code adjustments as per error handling standard (#23031) * Feature/container lisiting complete actions (#23030) * [WIP] Added Container listing and filters to Container list page * [WIP] Refactor Container list to use already provided Container Interface * [WIP] Container status is now displayed correctly * [WIP] Updated unit tests and minor refactor * Fixed unit test and listing data table * Added template outlet before listing table search, Container list style and ui refactor * Added strings to Language file and updated string keys in Container List component * [WIP] Added actions and Container service to handle actions * Updated unit tests * Added Component Store to Container Component * Modified container list component to better use selectors * moved activeRoue logic to store * Refactored ContainerList functionality to ContainerListStore * Method name refactor and State update minimisation * Fixed state initialization * [WIP] Added context menu actions and updated tests * Fixed Unit tests * Fixed Unit tests * Update core-web/apps/dotcms-ui/src/app/api/services/dot-router/dot-router.service.ts Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com> * Update core-web/apps/dotcms-ui/src/app/portlets/dot-containers/container-list/container-list.component.ts Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com> * Context menu actions hooked up to container service, Updated unit tests * Fixed store logic and fixed typos * Refactored container list component methods to container list store, Fixed typos, Updated container routes Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com> * Category rest endpoints for Add category, Update category and get children categories (#23029) * Add category rest endpoint * curl test fix * rest endpoint added to get children categories by parent inode * curl/postman tests * addressed PR comments and also renamed API from children to _children * reverted API name from _children to children * Updated API documentation * Code changes as per suggestions from code reviewing team * removed unnecessary imports * Update category rest endpoint added * little changes * fix for the curl test * Delete category rest endpoint (#23080) * Delete category rest endpoint * addressed feedback from BE team * Feature/container properties form (#23020) * Added Tabs to Container Create Page and updated translation strings * Added container properties component and added Inplace editor to it * Removed unused comment * [WIP] Properties form UI updated * Added Monaco Editor to Properties Form * add history and permission iframe * refactoring * create edit route for container and resolver * Added controls to container form * change component and folders name * Added method docs, Added translations, Minor fixes * Added missing translations * Added MonacoEditor type model for reusability * CSS refactor * CSS refactor * Renamed container create component as DotContainerCreateComponent * Component and SCSS refactor * Refactored Loop editor to new component * Update core-web/apps/dotcms-ui/src/app/portlets/dot-containers/dot-container-create/dot-container-history/dot-container-history.component.ts Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com> * Update core-web/apps/dotcms-ui/src/app/portlets/dot-containers/dot-container-create/dot-container-permissions/dot-container-permissions.component.ts Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com> * Refactored Content Editor to new component * Fixed Permissions and History componanets * change css style and remove unnecessary ng deep * change css style and remove unnecessary ng deep * Update core-web/apps/dotcms-ui/src/app/portlets/dot-containers/dot-container-create/dot-container-create.component.scss Co-authored-by: Freddy Montes <freddymontes@gmail.com> * Update core-web/apps/dotcms-ui/src/app/portlets/dot-containers/dot-container-create/dot-content-editor/store/dot-content-editor.store.ts Co-authored-by: Freddy Montes <freddymontes@gmail.com> * Removed unnecessary monaco editor initializations * fixed box height issue Co-authored-by: Zulqarnain Huda <zulqarnain.huda@venturedive.com> Co-authored-by: zulqarnainvd <113915849+zulqarnainvd@users.noreply.github.com> Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com> Co-authored-by: Freddy Montes <freddymontes@gmail.com> * Rest endpoint to update categories for sortOrder (#23091) * Rest endpoint to update categories for sortOrder * updated credentials * Addressed PR feedback * add permissions and history tab and load Iframe in Tabs (#23092) * add permissions and history tab and load Iframe in Tabs * write test cases using host component method and use variable in scss * Export categories rest endpoint (#23108) * Export categories rest endpoint * addressed PR feedback * Add/Get container details (#23126) * improvements in old code * add container rest endpoint added * Container details endpoint added to fetch container + structures info combinely * curl test + improvements * addressed PR feedback for _add rest endpoint * removed details endpoint and added support in the live and working endpoint to fetch contentTypes * code cleanup * Import categories rest endpoint (#23125) * Import categories rest endpoint * addressed PR feedback on categories import * addressed further feedback on categories import * Addressed PR feedback * converted categoryDTO to immutable * container rest endpoint modified to accept container code changes (#23157) * container rest endpoint modified to accept container code changes * curl/postman test added * Curl test fix (#23161) * changed admin user's password * fixed curl test * updated tests assertions * removed obsolete code/classes for categories (#23168) * removed obsolete code/classes for categories * Removed useless entries * removed servlet-mapping from web.xml * Feature/categories permissions (#23047) * categories initialization * fix unit test of category component * add Category Table and actions * add sub category beadcrumb and update sub category in table * modify subCategoryUrl and fix typo in table * add permission component and create a store * change folder name and css class convention * add docs and refactor the code * add doc * disable home button * changing code according to suggestions and write unit test of categorly listing component * add action header and Table UI of categories * add pagination and search filter * feat: working on categories * feat: working on categories * add pagination and search filter * refactoring and change doc * otCMS/core#23253 Categories: Fix the sort order in the endpoint * Revert "removed obsolete code/classes for categories (#23168)" (#23288) This reverts commit 2762511. * Container Form (#23110) * Added Simple form to container properties * add confirmation dialog on clear * Container can now be added using the simple form * fix create container route issue and get data in container properties * Added inplace data variable and fixed inplace CSS * Form is now editable * add Variable popup model * Added form validation and disabled button on zero max contentlets * Load content type from different source * add content type to menu state * get contentStructure value from child component to parent * Variable modal now works * Fixes to container add code * Addressed Feedback * Addressed Feedback * set variable in editor * Added update logic, Fixed failing unit tests * Fixed faorm initilisation issue * Addressed Feedback * changes according to PR * Fixed notification issue in container list * Fixed container list empty messages and linked butoon to create container * changes according to new API and requested PR changes * changes according to PR and working fedback UI 3 issues * Container Add form CSS Fixes * Added label and CSS fixes * Fixed clear button * Title field now enabled on container Add form * disable save button when required fields is empty or on edit value is not changed * #23144 Added API Link Component, Fixed button text * fix UI issues * fix UI issues and test cases * refactor code * Fixed CSS, Updated url to load system containers * Disabled interaction in container list for System Container * Updated tests * fix contentType Variable issue and container listing scroll issue * Removed optional identifier from container Request * fix reported issues * Removed from container properties template * refactoring and change name of resolver * PR requested changes * remove validation of description field * Conatiner Properties Form UI Fixes * Implemented Control Value Accessor for DotLoopEditor Component * Code impovements and fixes * #23146 Refactored Content Editor component into a angular form control * #23146 [WIP] Adding data to form control * Rename code component Co-authored-by: Zulqarnain Huda <zulqarnain.huda@venturedive.com> Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com> * get categories childrens and add breadcrumb (#23260) * get categories childrens and add breadcrumb * refactor: changes according to PR * refactor: add unit test case of category listing component * #23252 working on categories feedbacks and write test cases * #23252 working on categories feedbacks and write test cases * Fix tests build for containers * Clean up model * Clean up renamed container * #23252 fix category filter issue (#23308) * Added children count in the top level categories list (#23263) * Added children count in the top level categories list * added categories paginator for additional information * Addressed PR feedback * added line space at line number 94 * added java doc on the CategoryResource API + added postman tests * Fix import Co-authored-by: Daniel Silva <daniel.silva@dotcms.com> Co-authored-by: hassan-mustafa-baig <111717530+hassan-mustafa-baig@users.noreply.github.com> Co-authored-by: motasimvd <62100713+motasimvd@users.noreply.github.com> Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com> Co-authored-by: Zulqarnain Huda <zulqarnain.huda@venturedive.com> Co-authored-by: zulqarnainvd <113915849+zulqarnainvd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Checklist
Additional Info
** any additional useful context or info **
Screenshots