Issue 24916 favorite pages unable to create bookmark image for members page - Fix for Firefox #24993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarQube Quality Gate
|
fmontes
approved these changes
May 19, 2023
fmontes
deleted the
issue-24916-favorite-pages-unable-to-create-bookmark-image-for-members-page-firefox
branch
jdotcms
pushed a commit
that referenced
this pull request
May 26, 2023
… page - Fix for Firefox (#24993) * Fixing issue with Firefox * Adding firefox fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
🤖 Generated by Copilot at c229af3
Refactored
DotHtmlToImagecomponent to use a helper method for accessing the iframe document instead of state properties. This improves readability and performance of the component.Checklist
Additional Info
** any additional useful context or info **
Screenshots
Firefox:
Firefox SPA:
