Fix #25805: Containers Portlet only show containers from current site #25966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-from-current-site
…s-from-current-site
…s-from-current-site
…s-from-current-site
…t-site' of https://github.com/dotCMS/core into issue-25805-containers-only-show-containers-from-current-site
…params on navigation
…t-site' of https://github.com/dotCMS/core into issue-25805-containers-only-show-containers-from-current-site
manuelrojas
approved these changes
Sep 1, 2023
rjvelazco
requested changes
Sep 1, 2023
.../apps/dotcms-ui/src/app/portlets/dot-containers/container-list/container-list.component.html
Show resolved
Hide resolved
…s-from-current-site
…s-from-current-site
…s-from-current-site
…s-from-current-site
jdotcms
approved these changes
Sep 5, 2023
…s-from-current-site
|
SonarQube Quality Gate
|
rjvelazco
approved these changes
Sep 5, 2023
fmontes
approved these changes
Sep 7, 2023
| private dotContainersService: DotContainersService | ||
| private dotContainersService: DotContainersService, | ||
| private paginatorService: PaginatorService, | ||
| private dotSiteService: SiteService | ||
| ) { | ||
| super(null); |
There was a problem hiding this comment.
Comment on lines
+88
to
+91
| ([[isEnterprise, hasEnvironments], containers]: [ | ||
| [boolean, boolean], | ||
| DotContainer[] | ||
| ]) => { |
There was a problem hiding this comment.
This is too complicated, we can make this an object like:
{
isEnterprise: boolean,
hasEnvironments: boolean,
containers: DotContainer[]
}
We might have to modify the resolver... but if you ask me with this approach the resolver is not doing anything.
| * @memberof DotContainerListStore | ||
| */ | ||
| private patchContainers(containers: DotContainer[]): void { | ||
| this.patchState({ |
| </div> | ||
| </dot-action-header> | ||
| <p-table | ||
| *ngIf="vm.tableColumns && vm.actionHeaderOptions" |
Comment on lines
+8
to
+12
| dot-portlet-box { | ||
| display: flex; | ||
| flex-direction: column; | ||
| overflow-y: auto; | ||
| } |
There was a problem hiding this comment.
dot-portlet-box supposed to work without any modifications... should we make this global?
Comment on lines
+20
to
+24
| display: flex; | ||
| flex-direction: column; | ||
| height: 100%; | ||
| justify-content: space-between; | ||
| background: $white; |
fmontes
deleted the
issue-25805-containers-only-show-containers-from-current-site
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at d087b61
Summary
🎨🚀✅
Refactored the container list component to use the
p-tablecomponent and theDotContainerListStoreservice for better UI and performance. Fixed a z-index issue with the content type selector component. Added a method and a test case for resetting extra parameters in the paginator service.Walkthrough
dot-listing-data-tablecomponent withp-tablecomponent for better performance and flexibility (link, link, link, link, link, link, link, link, link, link, link)dot-content-type-selectorcomponent anddivwith thecontainer-listing__header-optionsclass to thedot-action-headercomponent for common header actions (link, link, link)container-listcomponent styles for the layout and responsiveness of thep-tablecomponent (link, link)DotContainerListStoreservice to manage the state and effects of the containers list (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)ElementRef,QueryList,ViewChild,ViewChildrenandMenuimports for the Angular decorators and types for thecontainer-listcomponent and thep-tablecomponent (link)InputTextModuleandTableModuleimports for the modules needed for thep-tablecomponent and the query input (link, link, link)ActionHeaderModuleimport for the module needed for thedot-action-headercomponent (link, link)actionsMenu,tableRows,selectedContainersanddestroy$properties for the references and variables for thecontainer-listcomponent and thep-tablecomponent (link)handleArchivedFilter,handleQueryFilter,loadDataPaginationEvent,handleActionMenuOpenandfocusFirstRowmethods for the query filter, the pagination, the action menu and the keyboard navigation for thep-tablecomponent (link)appendTo="body"attribute to thep-dropdownelement to fix a z-index issue with the dropdown menu (link)resetExtraParamsmethod to thePaginatorServiceclass to remove all extra parameters of the eventual request (link, link)DotRouterServiceimport from thecontainer-listcomponent since it is no longer needed with theDotContainerListStoreservice (link)columnsMockvariable from thecontainer-listcomponent spec since it is no longer needed with thep-tablecomponent (link)getContainersWithDisabledEntitiesmethod from thecontainer-listcomponent since it is no longer needed with theDotContainerListStoreservice (link)Screenshots
Screen.Recording.2023-09-01.at.1.04.54.PM.mov