Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Containers] : Only show containers from current site #25805

Closed
Tracked by #23140
fmontes opened this issue Aug 16, 2023 · 2 comments · Fixed by #25966
Closed
Tracked by #23140

[Containers] : Only show containers from current site #25805

fmontes opened this issue Aug 16, 2023 · 2 comments · Fixed by #25966
Assignees
@jcastro-dotcms @zJaaal
Labels
OKR : Core Features Owned by Will Priority : 3 Average QA : Approved QA : Passed Internal Release : 23.10.24 Bug-Fixing Team : Lunik Type : Defect

Comments

@fmontes
Copy link
Member

fmontes commented Aug 16, 2023 •
edited

Parent

#23140

Problem Statement

In the containers porlet we are listing containers from all site.

Steps to Reproduce

  1. Log in to dotCMS
  2. Create 2 sites
  3. Add a container to second site
  4. Navigate to the New Containers Portlet (http://localhost:8080/dotAdmin/#/containers)
  5. Notice that containers from all sites are listed

Acceptance Criteria

The Containers Portlet should only list containers from the current site.

External Links

N/A

Assumptions & Initiation Needs

The containers endpoint should take the site id.

Quality Assurance Notes & Workarounds

N/A
@fmontes fmontes mentioned this issue Aug 16, 2023
Closed
@fmontes fmontes changed the title [Containers] : Only Showing From Current Site [Containers] : Only show containers from current site Aug 17, 2023
@fmontes fmontes mentioned this issue Aug 24, 2023
Closed
@zJaaal zJaaal self-assigned this Aug 24, 2023
@zJaaal zJaaal linked a pull request Aug 31, 2023 that will close this issue
Fix #25805: Containers Portlet only show containers from current site #25966
Merged
fmontes pushed a commit that referenced this issue Sep 7, 2023
@zJaaal
Fix #25805: Containers Portlet only show containers from current site (…
da4bce8 
…#25966)

* refactor (containers portlet): table is showing and partially working

* fix (containers list module): querying and pagination were broken

* fix (containers list styles): table was overflowing

* dev (container list module): add missing functionalities

* copywritting (container list component): fix comment

* fix (container list tests): fixed some tests that were broken

* dev (container list test): add and fix tests

* copywirtting (container list test): delete unnecessary comment

* fix (dot containers store): portlet not initializing on navigation

* fix (dot containers store): pagination service is not cleaning extra params on navigation

* dev (containers list store): small refactor to getbyHost

* fix (containers list test): fix broken tests
@jcastro-dotcms jcastro-dotcms self-assigned this Sep 11, 2023
@jcastro-dotcms
Copy link
Contributor

INTERNAL QA: PASSED

  • Docker Image: master_3cd5549_SNAPSHOT

The Containers portlet is only displaying the Containers of the selected Site now.

@josemejias11
Copy link

josemejias11 commented Sep 18, 2023 •
edited

Approved: Tested on master_7713bff_SNAPSHOT, Docker, macOS 13.0, FF v113.0
Screenshot 2023-09-18 at 9 45 42 AM

@fmontes fmontes closed this as completed Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcastro-dotcms jcastro-dotcms

@zJaaal zJaaal

Labels
OKR : Core Features Owned by Will Priority : 3 Average QA : Approved QA : Passed Internal Release : 23.10.24 Bug-Fixing Team : Lunik Type : Defect
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #25805: Containers Portlet only show containers from current site dotCMS/core
4 participants
@fmontes @jcastro-dotcms @zJaaal @josemejias11