Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #26597: Old Edit Content Add Min Height to Text Area #26598

Merged
merged 4 commits into from
Nov 7, 2023

Conversation

zJaaal
Copy link
Contributor

@zJaaal zJaaal commented Nov 2, 2023

πŸ€– Generated by Copilot at a554c42

Summary

πŸŽ¨πŸ› οΈπŸ“

This pull request enhances the text area and combo box widgets in the dotCMS UI. It adds a minimum height and a vertical resize option to the text area, and improves the font-weight and alignment of the combo box menu items in the dotcms.css and dotcms.scss files.

There once was a pull request made
To improve how some widgets displayed
It added some style
To text area and dotcms.css file
And made the text area resizable and well-laid

Walkthrough

  • Add minimum height and vertical resize option to text area widget in dotCMS UI (link, link, link)
  • Modify style of combo box menu popup in dotCMS UI to improve readability and clarity of menu options (link)

Screenshots

Screen.Recording.2023-11-02.at.12.56.45.PM.mov

@zJaaal zJaaal linked an issue Nov 2, 2023 that may be closed by this pull request
@zJaaal zJaaal changed the title Fix #26597: Old Edit Content Fix Text Area Min Height Fix #26597: Old Edit Content Add Min Height to Text Area Nov 2, 2023
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@fmontes fmontes merged commit 0005129 into master Nov 7, 2023
31 of 34 checks passed
@fmontes fmontes deleted the 26597-textareas-need-to-be-embiggened branch November 7, 2023 17:26
@fmontes
Copy link
Member

fmontes commented Nov 7, 2023

Pipeline is facing but since this was pure CSS code I decided to merge because it will not affect test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Textareas need to be embiggened.
6 participants