Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotCMS/core#26520 Fix how works DotMessageService #26893

Merged
merged 3 commits into from Dec 8, 2023
Merged

dotCMS/core#26520 Fix how works DotMessageService #26893

merged 3 commits into from Dec 8, 2023

Conversation

oidacra
Copy link
Member

@oidacra oidacra commented Dec 6, 2023 •
edited

Proposed Changes

  • Fix how works DotMessageService

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

@oidacra oidacra linked an issue Dec 6, 2023 that may be closed by this pull request
[UI] Unable to resolve translation keys #26894
Closed
@oidacra oidacra force-pushed the fix-issue-26520-translations branch from 5bc6552 to 5db1a36 Compare December 6, 2023 18:47
@oidacra oidacra marked this pull request as ready for review December 6, 2023 19:03
@dsilvam dsilvam added this pull request to the merge queue Dec 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 7, 2023
@oidacra oidacra force-pushed the fix-issue-26520-translations branch from 8cbc888 to a0aff2b Compare December 7, 2023 17:04
@dsilvam dsilvam added this pull request to the merge queue Dec 7, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 7, 2023
@oidacra oidacra force-pushed the fix-issue-26520-translations branch from a0aff2b to 8fb15ed Compare December 7, 2023 21:07
@oidacra oidacra added this pull request to the merge queue Dec 8, 2023
@oidacra oidacra removed this pull request from the merge queue due to a manual request Dec 8, 2023
@oidacra oidacra force-pushed the fix-issue-26520-translations branch from 175f897 to f86a0cc Compare December 8, 2023 01:30
@oidacra oidacra force-pushed the fix-issue-26520-translations branch from f86a0cc to b8b17c4 Compare December 8, 2023 01:31
@dotcms-sonarqube dotCMS-sonarqube
Copy link

Quality Gate passed Quality Gate passed

The SonarQube Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
0.0% 0.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@dotcms-sonarqube dotCMS-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@oidacra oidacra added this pull request to the merge queue Dec 8, 2023
Merged via the queue into master with commit f5a29f5 Dec 8, 2023
42 checks passed
@oidacra oidacra deleted the fix-issue-26520-translations branch December 8, 2023 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmontes fmontes fmontes approved these changes

@hmoreras hmoreras hmoreras approved these changes

@zJaaal zJaaal zJaaal approved these changes

@rjvelazco rjvelazco rjvelazco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI] Unable to resolve translation keys
5 participants
@oidacra @fmontes @hmoreras @zJaaal @rjvelazco