test(postman) move postman tests to correct module #28328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickgonzalez
approved these changes
Apr 23, 2024
dsilvam
approved these changes
Apr 23, 2024
dcolina
approved these changes
Apr 23, 2024
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
spbolton
deleted the
issue-28239-relocate-postman-tests-to-correct-submodule
branch
Neehakethi
pushed a commit
that referenced
this pull request
Apr 24, 2024
Co-authored-by: Will Ezell <will@dotcms.com>
Neehakethi
pushed a commit
that referenced
this pull request
Apr 24, 2024
Co-authored-by: Will Ezell <will@dotcms.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
* issue-27725-Adding validations for middlename,nickname and birthday fields * issue-27725-Adding postman tests and changes needed * move postman tests to correct module (#28328) Co-authored-by: Will Ezell <will@dotcms.com> * Fixed issue on save (#28336) Co-authored-by: KevinDavilaDotCMS <kfariid@gmail.com> * #27805 Setting the correct token for NPM publishing. (#28342) Co-authored-by: Daniel Colina <daniel.colina@dotcms.com> * #27630 Fixing binary names on cli release NPM package. (#28341) Co-authored-by: Daniel Colina <daniel.colina@dotcms.com> * chore(edit-page-2): Updated logic to hide ema-tools menu (#28326) * Updated logic to hide ema-tools menu * Added missing message on save content from inline editing --------- Co-authored-by: KevinDavilaDotCMS <kfariid@gmail.com> Co-authored-by: Jalinson Diaz <zjaaaldev@gmail.com> --------- Co-authored-by: spbolton <steve.bolton@dotcms.com> Co-authored-by: Will Ezell <will@dotcms.com> Co-authored-by: Kevin Davila <144152756+KevinDavilaDotCMS@users.noreply.github.com> Co-authored-by: KevinDavilaDotCMS <kfariid@gmail.com> Co-authored-by: Daniel Enrique Colina Rodríguez <danielcolina@gmail.com> Co-authored-by: Daniel Colina <daniel.colina@dotcms.com> Co-authored-by: Jalinson Diaz <zjaaaldev@gmail.com> Co-authored-by: erickgonzalez <erick.gonzalez@dotcms.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Postman tests run as a separate maven submodule but to reduce changes and to allow old test scripts to work in the interim period we did not move the test sources but just referenced their local relative file locations. This can be confusing and breaks the modularity of the repository as well as makes it difficult to package the sources.
The test files themselves have just been moved without modification which should make conflict resolution easy but developers should be made aware of the change before and after this is merged.
Testing
This should just run and pass all the Postman tests as before