Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CICD): #27805 Setting the correct token for NPM publishing. #28342

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

dcolina
Copy link
Contributor

@dcolina dcolina commented Apr 24, 2024

Proposed Changes

  • We must use secrets.NPM_ORG_TOKEN instead of secrets.NPM_TOKEN.

Fixes

#27630

@dcolina dcolina requested a review from a team as a code owner April 24, 2024 13:50
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@nollymar nollymar added this pull request to the merge queue Apr 24, 2024
Merged via the queue into master with commit 161a6c8 Apr 24, 2024
14 checks passed
@nollymar nollymar deleted the issue-27805-fix-token-npm-build-nightly branch April 24, 2024 15:57
@dcolina dcolina linked an issue Apr 24, 2024 that may be closed by this pull request
Neehakethi pushed a commit that referenced this pull request Apr 24, 2024
Co-authored-by: Daniel Colina <daniel.colina@dotcms.com>
Neehakethi pushed a commit that referenced this pull request Apr 24, 2024
Co-authored-by: Daniel Colina <daniel.colina@dotcms.com>
github-merge-queue bot pushed a commit that referenced this pull request Apr 30, 2024
* issue-27725-Adding validations for middlename,nickname and birthday fields

* issue-27725-Adding postman tests and changes needed

* move postman tests to correct module (#28328)

Co-authored-by: Will Ezell <will@dotcms.com>

* Fixed issue on save (#28336)

Co-authored-by: KevinDavilaDotCMS <kfariid@gmail.com>

* #27805 Setting the correct token for NPM publishing. (#28342)

Co-authored-by: Daniel Colina <daniel.colina@dotcms.com>

* #27630 Fixing binary names on cli release NPM package. (#28341)

Co-authored-by: Daniel Colina <daniel.colina@dotcms.com>

* chore(edit-page-2): Updated logic to hide ema-tools menu (#28326)

* Updated logic to hide ema-tools menu

* Added missing message on save content from inline editing

---------

Co-authored-by: KevinDavilaDotCMS <kfariid@gmail.com>
Co-authored-by: Jalinson Diaz <zjaaaldev@gmail.com>

---------

Co-authored-by: spbolton <steve.bolton@dotcms.com>
Co-authored-by: Will Ezell <will@dotcms.com>
Co-authored-by: Kevin Davila <144152756+KevinDavilaDotCMS@users.noreply.github.com>
Co-authored-by: KevinDavilaDotCMS <kfariid@gmail.com>
Co-authored-by: Daniel Enrique Colina Rodríguez <danielcolina@gmail.com>
Co-authored-by: Daniel Colina <daniel.colina@dotcms.com>
Co-authored-by: Jalinson Diaz <zjaaaldev@gmail.com>
Co-authored-by: erickgonzalez <erick.gonzalez@dotcms.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

CLI: Generate NPM package nightly build
4 participants