Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I would like to request pull by putting the mock server function in this library. Is it possible? #9

Closed
uk1996 opened this issue Mar 27, 2023 · 3 comments

Comments

@uk1996
Copy link
Contributor

uk1996 commented Mar 27, 2023

Hello, I am a developer who is developing a gateway using the fastapi_gateway library. But when the service to connect to the gateway was not developed, I wanted to use the gateway as a mock server. Therefore, by adding the bool type mock parameter of the route decoder, I will distinguish whether the corresponding API of the gateway is connected to the service, and if the mock is True, I will respond to the sample data added to the responses parameter. Is this effective in your opinion? If you think it's efficient, Is it okay if I develop the function and make a pull request?

@uk1996 uk1996 changed the title I would like to request merge by putting the mock server function in this library. Is it possible? I would like to request pull by putting the mock server function in this library. Is it possible? Mar 27, 2023
@dotX12
Copy link
Owner

dotX12 commented Mar 31, 2023

@uk1996, hello!
It seems to me that this is clearly not the task of the gateway, but you need to mock the answer on the final server.

@dotX12
Copy link
Owner

dotX12 commented Mar 31, 2023

image

@uk1996
Copy link
Contributor Author

uk1996 commented Apr 3, 2023

I understand, thank you for taking the time to reply!

@dotX12 dotX12 closed this as completed Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants