Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalar lists are not queried if the info object is omitted #56

Closed
marktani opened this issue Feb 22, 2018 · 2 comments
Closed

Scalar lists are not queried if the info object is omitted #56

marktani opened this issue Feb 22, 2018 · 2 comments

Comments

@marktani
Copy link

Omitting the info object from a query is supposed to fetch all scalar fields. This does not seem to be the case for scalar list fields.

Consider this Prisma data model:

type Book {
  id: ID! @unique
  title: String!
  page: [Int!]!
}

If I run this resolver:

const resolvers = {
  Query: {
    async allBooks(parent, args, ctx, info) {
      return await ctx.db.query.books({}) // omitting `info`
    }
  },
}

The result contains id and title, but not page.

Moved from here: prisma-labs/prisma-binding#114

@kbrandwijk
Copy link
Contributor

kbrandwijk commented Feb 22, 2018

Change required here: https://github.com/graphql-binding/graphql-binding/blob/master/src/info.ts#L36-L47.

Use the utility functions from https://github.com/graphql/graphql-js/blob/master/src/type/definition.js to get the correct types (isListType, isScalarType, etc.).

Also, this is not a bug, but an enhancement, as a scalar list field is not a plain scalar field.

@Urigo
Copy link
Collaborator

Urigo commented May 26, 2020

Thank you for reporting.

In the last few months, since the transition of many libraries under The Guild's leadership, We've reviewed and released many improvements and versions to graphql-cli, graphql-config and graphql-import.

We've reviewed graphql-binding, had many meetings with current users and engaged the community also through the roadmap issue.

What we've found is that the new GraphQL Mesh library is covering not only all the current capabilities of GraphQL Binding, but also the future ideas that were introduced in the original GraphQL Binding blog post and haven't come to life yet.

And the best thing - GraphQL Mesh gives you all those capabilities, even if your source is not a GraphQL service at all!
it can be GraphQL, OpenAPI/Swagger, gRPC, SQL or any other source!
And of course you can even merge all those sources into a single SDK.

Just like GraphQL Binding, you get a fully typed SDK (thanks to the protocols SDKs and the GraphQL Code Generator), but from any source, and that SDK can run anywhere, as a connector or as a full blown gateway.
And you can share your own "Mesh Modules" (which you would probably call "your own binding") and our community already created many of those!
Also, we decided to simply expose regular GraphQL, so you can choose how to consume it using all the awesome fluent client SDKs out there.

If you think that we've missed anything from GraphQL Binding that is not supported in a better way in GraphQL Mesh, please let us know!

@Urigo Urigo closed this as completed May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants