Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versioning #169

Closed
arhimede opened this issue Nov 9, 2022 · 7 comments · Fixed by #291
Closed

versioning #169

arhimede opened this issue Nov 9, 2022 · 7 comments · Fixed by #291
Assignees
Labels
5.x question Further information is requested

Comments

@arhimede
Copy link
Member

arhimede commented Nov 9, 2022

do we want to prepare it for versioning ?

@arhimede arhimede added the question Further information is requested label Nov 9, 2022
@arhimede
Copy link
Member Author

not classical versioning, but by using sunset header
evolution strategy

https://datatracker.ietf.org/doc/html/rfc8594

https://api-platform.com/docs/core/deprecations/

@arhimede arhimede added the 5.x label May 28, 2024
@arhimede
Copy link
Member Author

@arhimede
Copy link
Member Author

arhimede commented Jun 4, 2024

@arhimede
Copy link
Member Author

arhimede commented Jun 5, 2024

  1. add the Sunset header to the response
  2. for the HOME endpoint, add the Deprecated header , for instance say that the metod will be changed from GET to POST on Jan 1, 2025
  3. add the new method , POST , for that header
  4. this new POST method will still return something extra ?
  5. Question : the sunset header, even emtpy, is always present ? check api-platform
  6. add to the endpoint list a new column: Deprecated, value the data when is deprecated

@arhimede
Copy link
Member Author

arhimede commented Jun 5, 2024

Example:
HEADER
sunset: Wed,01 Jan 2025 00:00:00 +0000
Link: http://example.net/sunset;rel="sunset";type="text/html"

linked resource provides sunset policy information about the service context

@arhimede
Copy link
Member Author

@arhimede
Copy link
Member Author

arhimede commented Jun 17, 2024

  1. in config/autoload/local.php , below the variable $baseUrl, add a GENERIC versioning page URL

example: $versioningUrl = 'https://docs.dotkernel.org/api-documentation/v5/core-features/versioning';

  1. IF the variable $versioningUrl is NOT NULL, AND a specific resource is marked as deprecated , send the header

Link: https://docs.dotkernel.org/api-documentation/v5/core-features/versioning;rel="sunset";type="text/html"

  1. On a specific endpoint, if there is a specific URL which explains that deprecation , send that specific url in Link header

@alexmerlin alexmerlin linked a pull request Jun 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.x question Further information is requested
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants