Skip to content
This repository has been archived by the owner on Dec 17, 2023. It is now read-only.

Vagrant 1.1 support #47

Closed
jimmycuadra opened this issue Mar 15, 2013 · 5 comments · Fixed by #50
Closed

Vagrant 1.1 support #47

jimmycuadra opened this issue Mar 15, 2013 · 5 comments · Fixed by #50

Comments

@jimmycuadra
Copy link
Contributor

I'm interested in working on Vagrant 1.1 support, if it's not already being worked on. (The 1.1 branch hasn't been updated in many months.) How would you like to go about support for 1.1? Do you want to just convert everything to the 1.1 plugin API, or keep the gem compatible with 1.0.x while also working with 1.1? If the latter, do you want to create new classes in a v2 namespace within the gem and conditionally load files based on Vagrant version, or try to make the existing files work for both somehow?

@fsalum
Copy link

fsalum commented Mar 16, 2013

It would be great to have the plugin working on Vagrant 1.1

@fnordfish
Copy link
Member

I have some commits for vagrant 1.1 support in the pipe.
Supporting both, 1.1 and 1.0 is pretty difficult, since the internal API (accessing ui and ssh) changed a lot.

@fnordfish
Copy link
Member

I've just pushed my recent work toward vagrant 1.1 compatibility in a separate branch called "varant-1.1".

Looking at all those little changes in 2530447 I'd rather like to keep two versions of vagrant-vbguest (like 0.7 and 1.0) to support vagrant 1.0 and 1.1+ for a while.

For testing I followed @mitchellh 's advise using bundler.
So, what you can do is to create a Gemfile in your vagrant project like this:

source "https://rubygems.org"

gem "vagrant-vbguest", :git => 'https://github.com/dotless-de/vagrant-vbguest.git', :branch => 'vagrant-1.1'

Then, run bundle install to get both, vagrant ant vagrant-vbguest installed.
To run those versions you need to run bundle exec vagrant [...]

@jimmycuadra
Copy link
Contributor Author

I tried out the branch and it worked for me with Vagrant 1.1. Is there anything else that needs to be done before a new gem version is released?

@fnordfish
Copy link
Member

Well, currently the command is totally broken. This is due to the fact, that vagrant is calling "actions" and "commands" with different types of "environments" over which the rest of vbguest's internals stumbles.

On the other hand, fixing this is actually a good opportunity to achieve backwards compatibility.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants