-
Notifications
You must be signed in to change notification settings - Fork 207
Vagrant 1.1 support #47
Comments
It would be great to have the plugin working on Vagrant 1.1 |
I have some commits for vagrant 1.1 support in the pipe. |
I've just pushed my recent work toward vagrant 1.1 compatibility in a separate branch called "varant-1.1". Looking at all those little changes in 2530447 I'd rather like to keep two versions of vagrant-vbguest (like 0.7 and 1.0) to support vagrant 1.0 and 1.1+ for a while. For testing I followed @mitchellh 's advise using bundler. source "https://rubygems.org"
gem "vagrant-vbguest", :git => 'https://github.com/dotless-de/vagrant-vbguest.git', :branch => 'vagrant-1.1' Then, run |
I tried out the branch and it worked for me with Vagrant 1.1. Is there anything else that needs to be done before a new gem version is released? |
Well, currently the command is totally broken. This is due to the fact, that vagrant is calling "actions" and "commands" with different types of "environments" over which the rest of vbguest's internals stumbles. On the other hand, fixing this is actually a good opportunity to achieve backwards compatibility. |
I'm interested in working on Vagrant 1.1 support, if it's not already being worked on. (The 1.1 branch hasn't been updated in many months.) How would you like to go about support for 1.1? Do you want to just convert everything to the 1.1 plugin API, or keep the gem compatible with 1.0.x while also working with 1.1? If the latter, do you want to create new classes in a v2 namespace within the gem and conditionally load files based on Vagrant version, or try to make the existing files work for both somehow?
The text was updated successfully, but these errors were encountered: