RTLPlugin is losing !important on border-width

[sea1jxr]

// bug.less .selector { border-width: 1px 2px 3px 4px !important; }

Running:
dotless.compiler.exe -p:Rtl:forceRtlTransform=true bug.less

Actual:
.selector { border-width: 1px 4px 3px 2px; }

Expected:
.selector { border-width: 1px 4px 3px 2px; !important }

Summary:
Looks like the borders are correctly adjusted for RTL, but the !important decoration is lost.

[rytmis]

Are you running the latest version? I fixed a bunch of these issues in 1.5.1.

On 29 Aug 2015, at 01:14, sea1jxr notifications@github.com wrote:

// bug.less
.selector {
border-width: 1px 2px 3px 4px !important;
}

Running:
dotless.compiler.exe -p:Rtl:forceRtlTransform=true bug.less

Actual:
.selector {
border-width: 1px 4px 3px 2px;
}

Expected:
.selector {
border-width: 1px 4px 3px 2px; !important
}

Summary:
Looks like the borders are correctly adjusted for RTL, but the !important decoration is lost.

—
Reply to this email directly or view it on GitHub.

[sea1jxr]

This is version 1.5.1. I discovered this while upgrading from version 1.3.1.0 to 1.5.1. So this bug is on 1.5.1. I also noticed several RTL fixes, and I was able to remove workarounds that we had in place. Thank you for those.

-jeff

From: Lauri Kotilainen [mailto:notifications@github.com]
Sent: Sunday, August 30, 2015 12:05 AM
To: dotless/dotless dotless@noreply.github.com
Cc: sea1jxr sea1jxr@yahoo.com
Subject: Re: [dotless] RTLPlugin is losing !important on border-width (#485)

Are you running the latest version? I fixed a bunch of these issues in 1.5.1.

On 29 Aug 2015, at 01:14, sea1jxr notifications@github.com wrote:

// bug.less
.selector {
border-width: 1px 2px 3px 4px !important;
}

Running:
dotless.compiler.exe -p:Rtl:forceRtlTransform=true bug.less

Actual:
.selector {
border-width: 1px 4px 3px 2px;
}

Expected:
.selector {
border-width: 1px 4px 3px 2px; !important
}

Summary:
Looks like the borders are correctly adjusted for RTL, but the !important decoration is lost.

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fdotless%2fdotless%2fissues%2f485%23issuecomment-136094041&data=01%7c01%7cJeff.Reed%40microsoft.com%7cee7753c9bb664bf683bc08d2b1095dce%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=m7o%2fu0xcE1Gje3p75XRG2q8H%2fLAHBkYWS1X10m4BB54%3d.