-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion for API authentication and Identity Server #5833
Comments
Please do |
@blowdart Please update the Repository and Sample links, as we know that the repository has been merged to aspnet/AspNetCore Sample : https://github.com/aspnet/AspNetCore/tree/master/src/Identity/samples/ApiAuthSample |
I wanted to have a look at the sample, checked out the current master of this repo, but the ApiAuthSample project does not compile (using the
Which is strange, as the Any hints on what I need to do to get the sample running? |
I updated to the latest state of master branch yesterday, and the sample project still does not compile. The error changed to not being able to find the project info for
The ASP.NET repo by itself compiles without errors, when I run the restore.cmd or build.cmd in the root directory. Thing is, I should hand in a magazine article about that in 3 days, and I'd love to see that running before I hand in some stuff that maybe won't work for the readers :) Any ideas? |
@gingters I've been able to build and run the app without problems. There was a small issue due to us not updating the sample after some MVC change, but that's it. I recommend you run .\build.cmd /t:Restore from the repo root and then dotnet build from the project folder and that should get you on your way. |
I updated the repo again, followed your steps, and I still have the issue that the build can't find the project info for the |
It's working for me on the rel/2.2 branch. Clean checkout, run the build.cmd, then I run |
Then there must be some undocumented dependencies, or something else I can't find out. 🤔 Also on the I have the .NET Core SDK 3.0.100-preview-009812 installed, VS 2017, 2017 Preview and 2019 Preview. I used the |
It seems the sample has been moved to this location - ApiAuthSample |
Hi! One question, why everything related to SPA in https://github.com/aspnet/AspNetCore/blob/master/src/Identity/ApiAuthorization.IdentityServer/src/Options/ClientBuilder.cs is using Implicit Grant Type? Since December of last year I think it's not recommended https://tools.ietf.org/html/draft-ietf-oauth-security-topics-12#section-3.1.2 Thanks for all! |
The opinions of the OAuth folks are still in draft, and are the subject of some contention. While arguable same site cookies might provide the same protections we have problems with the implementation being different on Safari, because apple reads the spec a different way. Furthermore by sticking to JWT and the implicit flows we're opening up support for other applications by embedding Identity Server. It will be revisited again, but for now we're staying where we are. |
I think this is more about „implicit vs code + pkce“. Iirc we already discussed to move to code in a later preview. |
The links included in the issue above are invalid (404 pages). |
I have a project, configured using IdentityServerSPA, where everything works fine on a local dev machine, but there seems to be issues when validating tokens, when deployed to a Linux based App service on aspnet core 3.1. It looks like when hosted on Linux, the internal IdentityServerJwtBearerOptionsConfiguration.ResolveAuthorityAndKeysAsync method, sets the Authority and ValidIssuer to the internal docker IP as the host (127.0.0.1), obtained using the IdentityServer4.Extensions.GetIdentityServerIssuerUri, instead of the actual host name of the App Service Is there a solution or work around for this? |
@Pete-PlaytimeSolutions thanks for contacting us. This is a general discussion issue not meant for specific problems. I would check if you are forwarding the headers to the host appropriately or check how to configure that. If you still have issues afterwards, please file a separate issue (if you haven’t done so) so that we can follow up there. We won’t be updating this thread further for this topic. |
Thank you for contacting us. Due to a lack of activity on this discussion issue we're closing it in an effort to keep our backlog clean. If you believe there is a concern related to the ASP.NET Core framework, which hasn't been addressed yet, please file a new issue. This issue will be locked after 30 more days of inactivity. If you still wish to discuss this subject after then, please create a new issue! |
Some of you may have noticed that the Identity Server integration is now in the master branch along with a sample on how it all hangs together.
This issue is meant to centralize feedback as much as possible, so let's first discuss what this feature is aimed at and its limits
So, have at it.
The text was updated successfully, but these errors were encountered: