-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SaveChangesAsync() doc page #25
Comments
From @smitpatel Looks like issue in docs gen cc:@divega |
@dend do you know if this is a general issue with the way the cancellationToken = default pattern gets rendered when the API ref docs are generated? BTW, I tried to verify if this was happening on other APIs but all the new 2.1 APIs that happen to use this pattern seem to be missing from the .NET API Browser. E.g. https://docs.microsoft.com/en-us/dotnet/api/system.io.compression.gzipstream.writeasync?view=netcore-2.1 is missing this overload: public override ValueTask WriteAsync(ReadOnlyMemory<byte> buffer, CancellationToken cancellationToken = default(CancellationToken))
{ } cc: @mairaw |
I see the same behavior on apisof.net (/cc @terrajobst) Not sure if you can infer the default from reflection to be able to build the signature exactly (can't look right now) Probably it would be best to open an issue at https://github.com/mono/api-doc-tools/ for @joelmartinez to investigate |
Moved from dotnet/efcore#12751 posted by @erictrigo
Check out: https://docs.microsoft.com/en-us/dotnet/api/microsoft.entityframeworkcore.dbcontext.savechangesasync?view=efcore-2.1
Says signature for SaveChangesAsync is
public virtual System.Threading.Tasks.Task<int> SaveChangesAsync (System.Threading.CancellationToken cancellationToken = null);
If you try overriding SaveChangesAsync using the above example, it'll give you the following error:
Using
default(CancellationToken)
instead ofnull
solves the issue:public override async Task<int> SaveChangesAsync(CancellationToken cancellationToken = default(CancellationToken))
The text was updated successfully, but these errors were encountered: