-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review of the C# API #95
Comments
Seems like a good move to me to follow libTorch design. I find the C++ API nice and intuitive if converting from Python. Personally I think works well in C# (single TorchTensor <=> at::Tensor as opposed to typed varieties). The '_' for 'in place' in Python/libTorch is even growing on me - or is that a bit too un-C#? :) |
Yea I think we need to discuss on this. I don't think we want to make the C# api snake case, unless we want an API more close to Python (#76 ) |
Would agree with no snake case. I suppose the trailing underscore instead of 'InPlace' is rather snake-casey! |
Personally, I hope that the naming rules remain the same as PyTorch, reducing the memory burden of developers switching. |
Covered by #205 |
The C# API now mostly follow libTorch design. I think we need to check if this match C# users expectations.
The text was updated successfully, but these errors were encountered: