Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of the C# API #95

Closed
interesaaat opened this issue Jun 28, 2019 · 5 comments
Closed

Review of the C# API #95

interesaaat opened this issue Jun 28, 2019 · 5 comments

Comments

@interesaaat
Copy link
Contributor

The C# API now mostly follow libTorch design. I think we need to check if this match C# users expectations.

@joemoorhouse
Copy link
Contributor

Seems like a good move to me to follow libTorch design. I find the C++ API nice and intuitive if converting from Python. Personally I think works well in C# (single TorchTensor <=> at::Tensor as opposed to typed varieties). The '_' for 'in place' in Python/libTorch is even growing on me - or is that a bit too un-C#? :)

@interesaaat
Copy link
Contributor Author

Yea I think we need to discuss on this. I don't think we want to make the C# api snake case, unless we want an API more close to Python (#76 )

@joemoorhouse
Copy link
Contributor

Would agree with no snake case. I suppose the trailing underscore instead of 'InPlace' is rather snake-casey!

@Oceania2018
Copy link

Personally, I hope that the naming rules remain the same as PyTorch, reducing the memory burden of developers switching.

@dsyme
Copy link
Contributor

dsyme commented Mar 19, 2021

Covered by #205

@dsyme dsyme closed this as completed Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants