format-local does not exist in git 1.8.3

[twimpiex]

to be able to set the modification date with older git versions (ie on EL 7) you should use another date option (iso)

[monojenkins]

Hello! I'm the build bot for the Mono project.

I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done.

Contributors can ignore this message.

[dnfclas]

Hi @twimpiex, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

[jonpryor]

touch(1) on OS X does not support the touch --date option, nor does FreeBSD, which means that this patch would break existing build behavior on macOS.

[twimpiex]

Do you prefer a general solutions or is a condition switch on the OS?

[jonpryor]

Similar code exists in multiple places:

$ git grep 'touch -m -t'
build-tools/android-toolchain/android-toolchain.targets:        Command="touch -m -t `git log -1 --format=%25cd --date=format-local:%25Y%25m%25d%25H%25M.%25S` Makefile"
build-tools/libzip/libzip.targets:        Command="touch -m -t `git log -1 --format=%25cd --date=format-local:%25Y%25m%25d%25H%25M.%25S` CMakeLists.txt"
build-tools/mono-runtimes/mono-runtimes.targets:        Command="touch -m -t `git log -1 --format=%25cd --date=format-local:%25Y%25m%25d%25H%25M.%25S` autogen.sh"
build-tools/mono-runtimes/mono-runtimes.targets:        Command="touch -m -t `git log -1 --format=%25cd --date=format-local:%25Y%25m%25d%25H%25M.%25S` Makefile.config.in"
src/sqlite-xamarin/sqlite-xamarin.targets:        Command="touch -m -t `git log -1 --format=%25cd --date=format-local:%25Y%25m%25d%25H%25M.%25S` README.version"

This PR didn't touch most of them.

What I would instead suggest is to add a new GitCommitTime task to xa-prep-tasks.dll, modeled after e.g. the <GitBranch/> task:

public partial class GitCommitTime : Git {
    // Inherited from Git
    public  ITaskItem       WorkingDirectory    { get; set; }

    // Added
    [Output]
    public  string          Time                { get; set; }
}

This new GitCommitTime task would invoke git --format=%cd --date=format-local:%Y%m%d%H%M.%S, and store the printed value into GItCommitTime.Time. The format of GitCommitTime.Time should be a value that is supported by the Touch.Time property.

Usage would thus replace:

<Exec
      Command="touch -m -t `git log -1 --format=%25cd --date=format-local:%25Y%25m%25d%25H%25M.%25S` autogen.sh"
      WorkingDirectory="$(MonoSourceFullPath)"
/>

With:

<GitCommitTime
    WorkingDirectory="$(MonoSourceFullPath)"
    ToolPath="$(GitToolPath)"
    ToolExe="$(GitToolExe)">
  <Output TaskParameter="Time"   PropertyName="_MonoSourceTime" />
/>
<Touch Files="$(MonoSourceFullPath)\autogen.sh" Time="$(_MonoSourceTime)" />

---

Minor aside: why wasn't this done the first time? Because the <Exec/> task didn't provide a way to capture output into an MSBuild property, and it was faster to just do the nested exec than to write a new task at the time.

Additionally, the <GitCommitTime/> and <Touch/> task usage could be bundled together into a new @(SetGitCommitTime) item group and SetGitCommitTimes target, a'la @(RequiredProgram). Usage could then become:

<ItemGroup>
  <SetGitCommitTime Include="$(MonoSourceFullPath)\autogen.sh" />
</ItemGroup>

and updating the $(BuildDependsOn) property so that that SetGitCommitTimes is invoked "first."

[monojenkins]

Hello! I'm the build bot for the Mono project.

I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done.

Contributors can ignore this message.

[monojenkins]

Hello! I'm the build bot for the Mono project.

I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done.

Contributors can ignore this message.

[atsushieno]

I don't think this change is really in need anymore considering that people should be using fairly recent versions of git that does not expose known vulnerabilities. I'm closing this issue, but thanks for sending us a PR @twimpiex. (And please feel free to reopen this if it should be still alive.)