Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono-runtimes] Update @(MonoFacadeAssembly) #2450

Merged
merged 1 commit into from
Nov 26, 2018

Conversation

jonpryor
Copy link
Member

Fixes: #1879

Add the following Facade assemblies to @(MonoFacadeAssembly):

  • System.Buffers.dll
  • System.Memory.dll
  • System.Net.Http.Rtc.dll
  • System.Threading.Tasks.Extensions.dll

Note: list was reordered to be sorted as per sort(1), and
generated with the following shell code on macOS:

$ cd external/mono/mcs/class/Facades
$ for d in `find . -depth 1 -type d | grep -v 'netstandard\|System.Drawing.Primitives' | sort -f` ; do
  n=`basename "$d"`;
  echo "    <MonoFacadeAssembly Include=\"$n.dll\" />";
done | pbcopy

The netstandard and System.Drawing.Primitives directory are
excluded so that the comment and following @(MonoFacadeAssembly)
entries in ProfileAssemblies.projitems are still relevant.

@jonpryor jonpryor added this to the d16-0 milestone Nov 20, 2018
Copy link
Contributor

@marek-safar marek-safar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't include System.Net.Http.Rtc that one is desktop only

@marek-safar
Copy link
Contributor

For the shell script I'd suggest to get the list from the binary package Mono provides to XA

@jonpryor
Copy link
Member Author

@marek-safar suggested:

For the shell script I'd suggest to get the list from the binary package Mono provides to XA

This is a good idea, but requires that we have a binary mono archive to use, which does not currently exist for the mono/2018-06 branch that we're using, and might not exist for mono/2018-08 either...

Thus, for now, we need a way to determine (and update!) the Facade assembly list that doesn't involve the binary mono archive, and unless you have a better idea, using the contents of mcs/class/Facades is the best I've got.

@marek-safar
Copy link
Contributor

@jonpryor using binary package only changes the location where you run your script with. If 2018-06 does not use binary packages you will have same binary output in your local build of Mono under mcs/class/lib/monotouch/Facades getting it from there should be same as getting the list from the binary archive.

@jonpryor jonpryor force-pushed the jonp-update-facades-2018-06 branch 6 times, most recently from 91954c9 to f5c3ee2 Compare November 21, 2018 18:27
@jonpryor jonpryor dismissed marek-safar’s stale review November 21, 2018 18:28

System.Net.Http.Rtc has been removed.

Fixes: dotnet#1879

Add the following Facade assemblies to `@(MonoFacadeAssembly)`:

  * `System.Buffers.dll`
  * `System.Memory.dll`
  * `System.Threading.Tasks.Extensions.dll`

Note: list was reordered to be sorted as per **sort**(1), and
generated with the following shell code on macOS:

	$ cd external/mono/mcs/class/Facades
	$ for d in `find . -depth 1 -type d | grep -v 'netstandard\|System.Drawing.Primitives\|System.Net.Http.Rtc' | sort -f` ; do
	  n=`basename "$d"`;
	  echo "    <MonoFacadeAssembly Include=\"$n.dll\" />";
	done | pbcopy

The `netstandard` and `System.Drawing.Primitives` directories are
excluded so that the comment and following `@(MonoFacadeAssembly)`
entries in `ProfileAssemblies.projitems` are still relevant.

The `System.Net.Http.Rtc` directory is excluded because it is only for
use on Desktop profiles.
@jonpryor jonpryor merged commit bf2b59c into dotnet:master Nov 26, 2018
jonpryor added a commit that referenced this pull request Nov 29, 2018
Fixes: #1879

Add the following Facade assemblies to `@(MonoFacadeAssembly)`:

  * `System.Buffers.dll`
  * `System.Memory.dll`
  * `System.Threading.Tasks.Extensions.dll`

Note: list was reordered to be sorted as per **sort**(1), and
generated with the following shell code on macOS:

	$ cd external/mono/mcs/class/Facades
	$ for d in `find . -depth 1 -type d | grep -v 'netstandard\|System.Drawing.Primitives\|System.Net.Http.Rtc' | sort -f` ; do
	  n=`basename "$d"`;
	  echo "    <MonoFacadeAssembly Include=\"$n.dll\" />";
	done | pbcopy

The `netstandard` and `System.Drawing.Primitives` directories are
excluded so that the comment and following `@(MonoFacadeAssembly)`
entries in `ProfileAssemblies.projitems` are still relevant.

The `System.Net.Http.Rtc` directory is excluded because it is only for
use on Desktop profiles.
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants