-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mono-runtimes] Update @(MonoFacadeAssembly) #2450
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't include System.Net.Http.Rtc that one is desktop only
For the shell script I'd suggest to get the list from the binary package Mono provides to XA |
@marek-safar suggested:
This is a good idea, but requires that we have a binary mono archive to use, which does not currently exist for the mono/2018-06 branch that we're using, and might not exist for mono/2018-08 either... Thus, for now, we need a way to determine (and update!) the Facade assembly list that doesn't involve the binary mono archive, and unless you have a better idea, using the contents of |
@jonpryor using binary package only changes the location where you run your script with. If 2018-06 does not use binary packages you will have same binary output in your local build of Mono under |
91954c9
to
f5c3ee2
Compare
System.Net.Http.Rtc has been removed.
Fixes: dotnet#1879 Add the following Facade assemblies to `@(MonoFacadeAssembly)`: * `System.Buffers.dll` * `System.Memory.dll` * `System.Threading.Tasks.Extensions.dll` Note: list was reordered to be sorted as per **sort**(1), and generated with the following shell code on macOS: $ cd external/mono/mcs/class/Facades $ for d in `find . -depth 1 -type d | grep -v 'netstandard\|System.Drawing.Primitives\|System.Net.Http.Rtc' | sort -f` ; do n=`basename "$d"`; echo " <MonoFacadeAssembly Include=\"$n.dll\" />"; done | pbcopy The `netstandard` and `System.Drawing.Primitives` directories are excluded so that the comment and following `@(MonoFacadeAssembly)` entries in `ProfileAssemblies.projitems` are still relevant. The `System.Net.Http.Rtc` directory is excluded because it is only for use on Desktop profiles.
f5c3ee2
to
e5bf2c1
Compare
Fixes: #1879 Add the following Facade assemblies to `@(MonoFacadeAssembly)`: * `System.Buffers.dll` * `System.Memory.dll` * `System.Threading.Tasks.Extensions.dll` Note: list was reordered to be sorted as per **sort**(1), and generated with the following shell code on macOS: $ cd external/mono/mcs/class/Facades $ for d in `find . -depth 1 -type d | grep -v 'netstandard\|System.Drawing.Primitives\|System.Net.Http.Rtc' | sort -f` ; do n=`basename "$d"`; echo " <MonoFacadeAssembly Include=\"$n.dll\" />"; done | pbcopy The `netstandard` and `System.Drawing.Primitives` directories are excluded so that the comment and following `@(MonoFacadeAssembly)` entries in `ProfileAssemblies.projitems` are still relevant. The `System.Net.Http.Rtc` directory is excluded because it is only for use on Desktop profiles.
Fixes: #1879
Add the following Facade assemblies to
@(MonoFacadeAssembly)
:System.Buffers.dll
System.Memory.dll
System.Net.Http.Rtc.dll
System.Threading.Tasks.Extensions.dll
Note: list was reordered to be sorted as per sort(1), and
generated with the following shell code on macOS:
The
netstandard
andSystem.Drawing.Primitives
directory areexcluded so that the comment and following
@(MonoFacadeAssembly)
entries in
ProfileAssemblies.projitems
are still relevant.