-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compiler error when referencing a NetStandard 2.0 library using ValueTask<T> #1879
Comments
I'm not able to build this project with VS 2017 15.7.4 or current master (0b5ce8f). |
Build environment information is essential to determine if it is expected or not. I could build ClassLibrary1 if I correctly run |
I think there is an issue in using |
Ok, here is a better summary of the problem:
|
In case this helps at all, here's some of my experience. When referencing a NuGet that has a dependency on
The project.assets.json file shows an empty placeholder for it: "System.Threading.Tasks.Extensions/4.5.1": {
"type": "package",
"compile": {
"ref/MonoAndroid10/_._": {}
},
"runtime": {
"lib/MonoAndroid10/_._": {}
}
} I noticed that
Does the milestone label |
@AdamDotNet ,4.5.0 has a another issue. see dotnet/corefx#29585 |
I think this is the same issue that I was having. My current workaround is to downgrade |
Fixes: dotnet#1879 Add the following Facade assemblies to `@(MonoFacadeAssembly)`: * `System.Buffers.dll` * `System.Memory.dll` * `System.Net.Http.Rtc.dll` * `System.Threading.Tasks.Extensions.dll` Note: list was reordered to be sorted as per **sort**(1), and generated with the following shell code on macOS: $ cd external/mono/mcs/class/Facades $ for d in `find . -depth 1 -type d | grep -v 'netstandard\|System.Drawing.Primitives' | sort -f` ; do n=`basename "$d"`; echo " <MonoFacadeAssembly Include=\"$n.dll\" />"; done | pbcopy The `netstandard` and `System.Drawing.Primitives` directory are excluded so that the comment and following `@(MonoFacadeAssembly)` entries in `ProfileAssemblies.projitems` are still relevant.
Fixes: dotnet#1879 Add the following Facade assemblies to `@(MonoFacadeAssembly)`: * `System.Buffers.dll` * `System.Memory.dll` * `System.Net.Http.Rtc.dll` * `System.Threading.Tasks.Extensions.dll` Note: list was reordered to be sorted as per **sort**(1), and generated with the following shell code on macOS: $ cd external/mono/mcs/class/Facades $ for d in `find . -depth 1 -type d | grep -v 'netstandard\|System.Drawing.Primitives' | sort -f` ; do n=`basename "$d"`; echo " <MonoFacadeAssembly Include=\"$n.dll\" />"; done | pbcopy The `netstandard` and `System.Drawing.Primitives` directory are excluded so that the comment and following `@(MonoFacadeAssembly)` entries in `ProfileAssemblies.projitems` are still relevant.
Fixes: dotnet#1879 Add the following Facade assemblies to `@(MonoFacadeAssembly)`: * `System.Buffers.dll` * `System.Memory.dll` * `System.Net.Http.Rtc.dll` * `System.Threading.Tasks.Extensions.dll` Note: list was reordered to be sorted as per **sort**(1), and generated with the following shell code on macOS: $ cd external/mono/mcs/class/Facades $ for d in `find . -depth 1 -type d | grep -v 'netstandard\|System.Drawing.Primitives' | sort -f` ; do n=`basename "$d"`; echo " <MonoFacadeAssembly Include=\"$n.dll\" />"; done | pbcopy The `netstandard` and `System.Drawing.Primitives` directory are excluded so that the comment and following `@(MonoFacadeAssembly)` entries in `ProfileAssemblies.projitems` are still relevant.
Fixes: dotnet#1879 Add the following Facade assemblies to `@(MonoFacadeAssembly)`: * `System.Buffers.dll` * `System.Memory.dll` * `System.Net.Http.Rtc.dll` * `System.Threading.Tasks.Extensions.dll` Note: list was reordered to be sorted as per **sort**(1), and generated with the following shell code on macOS: $ cd external/mono/mcs/class/Facades $ for d in `find . -depth 1 -type d | grep -v 'netstandard\|System.Drawing.Primitives\|System.Net.Http.Rtc' | sort -f` ; do n=`basename "$d"`; echo " <MonoFacadeAssembly Include=\"$n.dll\" />"; done | pbcopy The `netstandard` and `System.Drawing.Primitives` directory are excluded so that the comment and following `@(MonoFacadeAssembly)` entries in `ProfileAssemblies.projitems` are still relevant.
Fixes: dotnet#1879 Add the following Facade assemblies to `@(MonoFacadeAssembly)`: * `System.Buffers.dll` * `System.Memory.dll` * `System.Net.Http.Rtc.dll` * `System.Threading.Tasks.Extensions.dll` Note: list was reordered to be sorted as per **sort**(1), and generated with the following shell code on macOS: $ cd external/mono/mcs/class/Facades $ for d in `find . -depth 1 -type d | grep -v 'netstandard\|System.Drawing.Primitives\|System.Net.Http.Rtc' | sort -f` ; do n=`basename "$d"`; echo " <MonoFacadeAssembly Include=\"$n.dll\" />"; done | pbcopy The `netstandard` and `System.Drawing.Primitives` directory are excluded so that the comment and following `@(MonoFacadeAssembly)` entries in `ProfileAssemblies.projitems` are still relevant.
Fixes: dotnet#1879 Add the following Facade assemblies to `@(MonoFacadeAssembly)`: * `System.Buffers.dll` * `System.Memory.dll` * `System.Net.Http.Rtc.dll` * `System.Threading.Tasks.Extensions.dll` Note: list was reordered to be sorted as per **sort**(1), and generated with the following shell code on macOS: $ cd external/mono/mcs/class/Facades $ for d in `find . -depth 1 -type d | grep -v 'netstandard\|System.Drawing.Primitives\|System.Net.Http.Rtc' | sort -f` ; do n=`basename "$d"`; echo " <MonoFacadeAssembly Include=\"$n.dll\" />"; done | pbcopy The `netstandard` and `System.Drawing.Primitives` directory are excluded so that the comment and following `@(MonoFacadeAssembly)` entries in `ProfileAssemblies.projitems` are still relevant.
Fixes: dotnet#1879 Add the following Facade assemblies to `@(MonoFacadeAssembly)`: * `System.Buffers.dll` * `System.Memory.dll` * `System.Threading.Tasks.Extensions.dll` Note: list was reordered to be sorted as per **sort**(1), and generated with the following shell code on macOS: $ cd external/mono/mcs/class/Facades $ for d in `find . -depth 1 -type d | grep -v 'netstandard\|System.Drawing.Primitives\|System.Net.Http.Rtc' | sort -f` ; do n=`basename "$d"`; echo " <MonoFacadeAssembly Include=\"$n.dll\" />"; done | pbcopy The `netstandard` and `System.Drawing.Primitives` directory are excluded so that the comment and following `@(MonoFacadeAssembly)` entries in `ProfileAssemblies.projitems` are still relevant.
Fixes: dotnet#1879 Add the following Facade assemblies to `@(MonoFacadeAssembly)`: * `System.Buffers.dll` * `System.Memory.dll` * `System.Threading.Tasks.Extensions.dll` Note: list was reordered to be sorted as per **sort**(1), and generated with the following shell code on macOS: $ cd external/mono/mcs/class/Facades $ for d in `find . -depth 1 -type d | grep -v 'netstandard\|System.Drawing.Primitives\|System.Net.Http.Rtc' | sort -f` ; do n=`basename "$d"`; echo " <MonoFacadeAssembly Include=\"$n.dll\" />"; done | pbcopy The `netstandard` and `System.Drawing.Primitives` directories are excluded so that the comment and following `@(MonoFacadeAssembly)` entries in `ProfileAssemblies.projitems` are still relevant. The `System.Net.Http.Rtc` directory is excluded because it is only for use on Desktop profiles.
Fixes: #1879 Add the following Facade assemblies to `@(MonoFacadeAssembly)`: * `System.Buffers.dll` * `System.Memory.dll` * `System.Threading.Tasks.Extensions.dll` Note: list was reordered to be sorted as per **sort**(1), and generated with the following shell code on macOS: $ cd external/mono/mcs/class/Facades $ for d in `find . -depth 1 -type d | grep -v 'netstandard\|System.Drawing.Primitives\|System.Net.Http.Rtc' | sort -f` ; do n=`basename "$d"`; echo " <MonoFacadeAssembly Include=\"$n.dll\" />"; done | pbcopy The `netstandard` and `System.Drawing.Primitives` directories are excluded so that the comment and following `@(MonoFacadeAssembly)` entries in `ProfileAssemblies.projitems` are still relevant. The `System.Net.Http.Rtc` directory is excluded because it is only for use on Desktop profiles.
Fixes: #1879 Add the following Facade assemblies to `@(MonoFacadeAssembly)`: * `System.Buffers.dll` * `System.Memory.dll` * `System.Threading.Tasks.Extensions.dll` Note: list was reordered to be sorted as per **sort**(1), and generated with the following shell code on macOS: $ cd external/mono/mcs/class/Facades $ for d in `find . -depth 1 -type d | grep -v 'netstandard\|System.Drawing.Primitives\|System.Net.Http.Rtc' | sort -f` ; do n=`basename "$d"`; echo " <MonoFacadeAssembly Include=\"$n.dll\" />"; done | pbcopy The `netstandard` and `System.Drawing.Primitives` directories are excluded so that the comment and following `@(MonoFacadeAssembly)` entries in `ProfileAssemblies.projitems` are still relevant. The `System.Net.Http.Rtc` directory is excluded because it is only for use on Desktop profiles.
Steps to Reproduce
Repro project: https://github.com/yinyue200/taskextest/tree/v2
Expected Behavior
Build successful
Actual Behavior
error CS0012: The type 'ValueTask<>' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Threading.Tasks.Extensions, Version=4.2.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'.
Version Information
Log File
The text was updated successfully, but these errors were encountered: