Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve visibility of helix job links #10375

Closed
2 tasks
BrennanConroy opened this issue Aug 10, 2022 · 4 comments
Closed
2 tasks

Improve visibility of helix job links #10375

BrennanConroy opened this issue Aug 10, 2022 · 4 comments
Assignees
Labels
Ops - Compliance First-responder-style issues handled by the Operations V-Team due to prioritization or urgency level

Comments

@BrennanConroy
Copy link
Member

  • This issue is blocking
  • This issue is causing unreasonable pain

Given a helix log like: this
Also, shown relevant part of it here:

  Sent Helix Job; see work items at https://helix.dot.net/api/jobs/e6df725b-7a21-4eab-a4c1-3c1e82c8b4be/workitems?api-version=2019-06-17
  Waiting for completion of job 26855278-036b-4ff1-ad64-9b77f79f6c58 on Ubuntu.1804.Amd64.Open
  Waiting for completion of job 55fe1e7f-ad79-42b5-b325-cf5e058a0dc1 on OSX.1100.Amd64.Open
  Waiting for completion of job e6df725b-7a21-4eab-a4c1-3c1e82c8b4be on Windows.11.Amd64.Client.Open
  Job 55fe1e7f-ad79-42b5-b325-cf5e058a0dc1 on OSX.1100.Amd64.Open is completed with 145 finished work items.
  Job 26855278-036b-4ff1-ad64-9b77f79f6c58 on Ubuntu.1804.Amd64.Open is completed with 145 finished work items.
  Job e6df725b-7a21-4eab-a4c1-3c1e82c8b4be on Windows.11.Amd64.Client.Open is completed with 175 finished work items.
  Stopping Azure Pipelines Test Run Ubuntu.1804.Amd64.Open
  Stopping Azure Pipelines Test Run OSX.1100.Amd64.Open
  Stopping Azure Pipelines Test Run Windows.11.Amd64.Client.Open

It would be helpful to have the Waiting for completion of job <id> on <queue> link to the job, I realize (now) that the job is linked to in the logs, but they can be scattered among all the other logs a build outputs.

Ask:
In the "Waiting for completion" summary section, put links to the jobs.

cc @markwilkie

@missymessa
Copy link
Member

@BrennanConroy
Copy link
Member Author

I think so, it gives the top level information specific to that OS/Job and everything else can be found by reading the json and following links.

@michellemcdaniel michellemcdaniel added the Ops - Compliance First-responder-style issues handled by the Operations V-Team due to prioritization or urgency level label Jan 5, 2023
MattGal added a commit to MattGal/arcade that referenced this issue Jan 6, 2023
@MattGal MattGal self-assigned this Jan 6, 2023
@MattGal
Copy link
Member

MattGal commented Jan 6, 2023

Created #12114. I chose to not include the details URL for authenticated runs since we cannot log the Api Access token (it'd just be converted to *** anyways) and the URL is kind of useless without that in authenicated scenarios.

At @ChadNedzlek 's suggestion I also added a link to the AzDO test runs in every "Stopping Azure Pipelines Test Run" message, since this is really where we'd like you to be looking.

@MattGal
Copy link
Member

MattGal commented Jan 17, 2023

This has made it into product repos (example) and seems good, closing.

@MattGal MattGal closed this as completed Jan 17, 2023
dotnet-bot pushed a commit to dotnet/dotnet that referenced this issue Jan 18, 2023
Diff: https://github.com/dotnet/arcade/compare/5a5ae41c42e475e280342b668e668ff34539e36d..e52b885a6ec2fc87c9e94b80d9ff7a862786390b

From: dotnet/arcade@5a5ae41
To: dotnet/arcade@e52b885

Commits:
  - Fix IsBionic calculation (#12053)
    dotnet/arcade@4fbf50a
  - use the correctly named PAT for cross-org publishing (#11986)
    dotnet/arcade@4a59bcf
  - Update dependencies from https://github.com/dotnet/templating build 20221231.2 (#12048)
    dotnet/arcade@d9401d9
  - Update dependencies from https://github.com/dotnet/arcade build 20230102.2 (#12057)
    dotnet/arcade@788db68
  - Add scorecards for 2022-11-02 (#11523)
    dotnet/arcade@2fe7be9
  - Update dependencies from https://github.com/dotnet/xliff-tasks build 20230103.1 (#12083)
    dotnet/arcade@bd09ac9
  - [main] Update dependencies from dotnet/arcade dotnet/sourcelink (#12085)
    dotnet/arcade@eae015f
  - Update dependencies from https://github.com/dotnet/xliff-tasks build 20230104.1 (#12092)
    dotnet/arcade@1480f8a
  - [main] Update dependencies from dotnet/arcade dotnet/sourcelink (#12094)
    dotnet/arcade@88ed671
  - Upgrade Arcade to .NET 8 SDK and TFM (#12096)
    dotnet/arcade@7502a87
  - [main] Update dependencies from dotnet/xliff-tasks dotnet/arcade (#12110)
    dotnet/arcade@ab45bb2
  - Update dependencies from https://github.com/dotnet/xliff-tasks build 20230106.1 (#12113)
    dotnet/arcade@92bf81c
  - [main] Update dependencies from dotnet/xharness dotnet/arcade (#12116)
    dotnet/arcade@f35bfa3
  - Add some extra logging to Helix runs as requested in dotnet/arcade#10375. (#12114)
    dotnet/arcade@c0fcdfd
  - Azure Pipelines has added support for variable templates. Add support in Arcade so dotnet/runtime can use this feature to de-duplicate some variable definitions. (#12104)
    dotnet/arcade@8760c92
  - Revert "Azure Pipelines has added support for variable templates. Add support in Arcade so dotnet/runtime can use this feature to de-duplicate some variable definitions. (#12104)" (#12121)
    dotnet/arcade@5730ab6
  - Avoid setting source control properties during design-time build (#11923)
    dotnet/arcade@53026f0
  - Update dependencies from https://github.com/dotnet/roslyn build 20230106.3 (#12133)
    dotnet/arcade@d360f5e
  - [main] Update dependencies from dotnet/xliff-tasks dotnet/arcade dotnet/sourcelink (#12127)
    dotnet/arcade@f7e0936
  - Enable template variables for Azure DevOps in Arcade-based jobs, try 2 (#12125)
    dotnet/arcade@034aa38
  [... commit list trimmed ...]

[[ commit created by automation ]]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ops - Compliance First-responder-style issues handled by the Operations V-Team due to prioritization or urgency level
Projects
None yet
Development

No branches or pull requests

4 participants