Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright override #12751

Closed
1 of 5 tasks
kant2002 opened this issue Mar 2, 2023 · 7 comments
Closed
1 of 5 tasks

Copyright override #12751

kant2002 opened this issue Mar 2, 2023 · 7 comments

Comments

@kant2002
Copy link
Contributor

kant2002 commented Mar 2, 2023

  • This issue is blocking
  • This issue is causing unreasonable pain

Release Note Category

  • Feature changes/additions
  • Bug fixes
  • Internal Infrastructure Improvements

Release Note Description

I work on the educational fork of F# and create derived package. I have a need to publish derived packages under different names with support for more keywords. So I was looking for a way to change default Microsoft copyright. Initially I thought that adding Copyright tag in Directory.Build.Props would be enough. But apparently that’s would be later overridden by this line.

<Copyright>$(CopyrightMicrosoft)</Copyright>

So I change CopyrightMicrosoft tag and that solve my issue. But because on the title “Tools that provide common build infrastructure for multiple .NET Foundation projects.” I was under impression that Arcade is primary for .Net Foundation projects but looks like it is Microsoft only for now.

So my request is following: is it possible to provide a way to override Copyright in better way?

@missymessa
Copy link
Member

/cc @terrajobst thoughts?

@vzarytovskii
Copy link
Member

vzarytovskii commented Mar 20, 2023

I have a change pending which will allow to build (a subset of) compiler with plain dotnet (not requiring running build scripts, arcade or proto compiler), for faster dev loop.

You can wait for for, and it should just work©, since it won't be including arcade sdk.

dotnet/fsharp#14677

@kant2002
Copy link
Contributor Author

I was thinking about how can I use FSharp.Compiler.Services separately, and I think that I still need full compiler build which I try to distribute as Nuget package. So even if FCS would work, I still like to have some option to augment Copyright.

@vzarytovskii
Copy link
Member

I was thinking about how can I use FSharp.Compiler.Services separately, and I think that I still need full compiler build which I try to distribute as Nuget package. So even if FCS would work, I still like to have some option to augment Copyright.

You'll be able to build compiler dll as part of that pr as well. It will include the corresponding project

@kant2002
Copy link
Contributor Author

kant2002 commented Apr 2, 2023

I was thinking a bit (really being stubborn and no willingn to change anything). But I probably still want to have VS integration package, even if I do not known what should I change and how far I from my goal.

@garath
Copy link
Member

garath commented Jun 15, 2023

@kant2002 dotnet/fsharp#14677 merged, does that solve this issue of the copyright?

@kant2002
Copy link
Contributor Author

@garath and @missymessa unfortunately FSharp Pr is not sufficient because it only produce part of the product. It does not affects VSIX for example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants