Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DarcLib] Case insensitive name matching #2058

Closed
jcagme opened this issue Feb 20, 2019 · 1 comment
Closed

[DarcLib] Case insensitive name matching #2058

jcagme opened this issue Feb 20, 2019 · 1 comment

Comments

@jcagme
Copy link
Contributor

jcagme commented Feb 20, 2019

@jcagme commented on Tue Feb 19 2019

In an auto-update scenario, when we determine what dependencies need to be updated in a repo+branch we are doing case sensitive comparison on the asset/dependency name, we should make this insensitive.

Change should happen around https://github.com/dotnet/arcade-services/blob/master/src/Microsoft.DotNet.Darc/src/DarcLib/Actions/Remote.cs#L290

FYI @mmitche

@mmitche
Copy link
Member

mmitche commented Apr 17, 2019

This got fixed recently (and there are test cases for it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants