-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Suggestion: Add "Cancel Helix Job" Build task #7113
Comments
This would be really helpful for the runtime-staging pipeline where we're battling with capacity issues on the Android devices Helix queue which means we run into timeouts quite often when a lot of work gets scheduled at the same time. This in turn exacerbates the issue because work items don't get canceled. |
This functionality already exists in the WaitForHelixJobCompletion task, If the task gets canceled the job is canceled. |
I know, I wrote it; this is for later one when they just want to explicitly cancel without cancelling the task. Long story, happy to regale you with it any time after 3 PM PST. |
Yeah the problem is when a build runs into the job timeout AzDO will just kill the process, so the cancellation code in WaitForHelixJobCompletion doesn't run. Until AzDO fixes this we'd like to run a subsequent task that uses |
We are definitely seeing higher pressure on machine queues - and this would likely help. Thoughts from others? How expensive do you think it would be to do @MattGal ? |
SWAG: 1-2 days. All the pieces are already there in the SDK, this would just be stitching them together. |
[Async Triage] the last poster has a good point. |
If this is causing pain and it's not expensive as per Matt's point, this could probably be done as part of FR? |
Yes, if used by the Helix Android runs to work around AzDO's limitation, it would drastically reduce pain in PRs that need Android testing because it would prevent hundreds of hours of usage of limited hardware. |
Grabbing this one as it should be pretty quick. |
As this is an Arcade change that's now in master, I am closing the issue; natural dependency flow should get it to the runtime team next week. |
As noted here: https://developercommunity.visualstudio.com/t/ADO-pipeline-timeouts-dont-cancel-the-s/1371617?space=21&entry=myfeedback&viewtype=all, it seems that the automated cancellation feature I built doesn't run as often as we'd expect because it's far more common for a build to time out than be cancelled via push. Perhaps ADO will fix this.
In the mean time, we could make it simpler to cancel jobs in this scenario by:
The text was updated successfully, but these errors were encountered: