Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add intermediate HubConnection states in Java client #12138

Open
mikaelm12 opened this issue Jul 12, 2019 · 4 comments
Open

Add intermediate HubConnection states in Java client #12138

mikaelm12 opened this issue Jul 12, 2019 · 4 comments
Labels
affected-few This issue impacts only small number of customers area-signalr Includes: SignalR clients and servers enhancement This issue represents an ask for new feature or an enhancement to an existing one severity-minor This label is used by an internal tool
Milestone
Backlog

Comments

@mikaelm12
Copy link
Contributor

After looking at our locking and state transitions, we should add intermediate connection states Connecting and Disconnecting. This is for better handling potential races between starting and stopping a connection.
Context: #12078 (comment)
@mikaelm12 mikaelm12 self-assigned this Jul 14, 2019
@mikaelm12 mikaelm12 added this to the 3.0.0-preview8 milestone Jul 14, 2019
@mikaelm12
Copy link
Contributor Author

Putting in preview 8 since this should help protect against potential races in the client.

@Eilon Eilon added the area-signalr Includes: SignalR clients and servers label Jul 15, 2019
@mikaelm12 mikaelm12 mentioned this issue Jul 15, 2019
Closed
@analogrelay
Copy link
Contributor

Triage: We'll leave this in preview 8 but it's not a top priority. We have identified some races and knocked those down. Hardening this seems like a good 3.1 candidate.

@analogrelay
Copy link
Contributor

Moving to backlog for 3.1

@analogrelay analogrelay modified the milestones: 3.0.0-preview8, Backlog Jul 26, 2019
@BrennanConroy BrennanConroy mentioned this issue Sep 17, 2019
Closed
@analogrelay analogrelay modified the milestones: Backlog, 5.0.0-preview1 Sep 17, 2019
@analogrelay
Copy link
Contributor

If we find specific bugs because of this, those are good candidates for 3.1. But just adding the intermediate states is for 5.0

@analogrelay analogrelay modified the milestones: 5.0.0-preview1, Backlog Mar 11, 2020
@vicancy vicancy mentioned this issue Aug 24, 2020
Closed
@BrennanConroy BrennanConroy added affected-few This issue impacts only small number of customers enhancement This issue represents an ask for new feature or an enhancement to an existing one severity-minor This label is used by an internal tool labels Nov 9, 2020 — with ASP.NET Core Issue Ranking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affected-few This issue impacts only small number of customers area-signalr Includes: SignalR clients and servers enhancement This issue represents an ask for new feature or an enhancement to an existing one severity-minor This label is used by an internal tool
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@analogrelay @pranavkm @Eilon @mikaelm12 @BrennanConroy