Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for flowing the Activity/distributed trace context via SignalR invocations #18711

Open
davidfowl opened this issue Jan 31, 2020 · 7 comments
Labels
affected-few This issue impacts only small number of customers area-signalr Includes: SignalR clients and servers enhancement This issue represents an ask for new feature or an enhancement to an existing one severity-minor This label is used by an internal tool
Milestone

Comments

@davidfowl
Copy link
Member

We need to make a provision in the SignalR hub protocol for flowing the distributed trace context. This will enable causality tracking across multiple SignalR applications or from an HTTP server calling a SignalR method. It's also worth thinking about what it means to flow the context back to the client for server -> client invocations.

@mkArtakMSFT mkArtakMSFT added the area-signalr Includes: SignalR clients and servers label Jan 31, 2020
@analogrelay analogrelay added the enhancement This issue represents an ask for new feature or an enhancement to an existing one label Jan 31, 2020
@analogrelay analogrelay added this to the Backlog milestone Jan 31, 2020
@analogrelay
Copy link
Contributor

If we expanded Hub Pipeline to work on the client as well, this could probably be done in that.

@davidfowl
Copy link
Member Author

@anurse it also needs to be done client side.

@SergeyKanzhelev We should have a quick sync about this.

@BrennanConroy BrennanConroy added affected-very-few This issue impacts very few customers severity-minor This label is used by an internal tool labels Nov 9, 2020 — with ASP.NET Core Issue Ranking
@ghost
Copy link

ghost commented Apr 6, 2021

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. Because it's not immediately obvious that this is a bug in our framework, we would like to keep this around to collect more feedback, which can later help us determine the impact of it. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@davidfowl davidfowl added affected-medium This issue impacts approximately half of our customers affected-few This issue impacts only small number of customers and removed affected-very-few This issue impacts very few customers affected-medium This issue impacts approximately half of our customers labels Apr 6, 2021
@davidfowl
Copy link
Member Author

We have headers in messages, we could finally use them here @BrennanConroy. It'll end up allocating async locals though...

@ghost
Copy link

ghost commented Jul 29, 2021

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@alexdresko
Copy link

Ha. I just spent a lot of time getting my .NET 6 application in my k8s cluster to post its metrics and traces through otelcol to jaeger, only to find out that the SignalR integration just isn't there. That's pretty disappointing from where I sit right now, so I'm leaving a comment to remind people that this is an important issue. :)

@phaza
Copy link

phaza commented Feb 1, 2023

For everyone else who struggles with this, there's work in progress here to fix this: #46164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected-few This issue impacts only small number of customers area-signalr Includes: SignalR clients and servers enhancement This issue represents an ask for new feature or an enhancement to an existing one severity-minor This label is used by an internal tool
Projects
None yet
Development

No branches or pull requests

6 participants