Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] New Azure Integration Packages in ASP.NET Core 5 #408 #19570

Closed
analogrelay opened this issue Mar 4, 2020 · 13 comments
Closed

[Discussion] New Azure Integration Packages in ASP.NET Core 5 #408 #19570

analogrelay opened this issue Mar 4, 2020 · 13 comments
Milestone

Comments

@analogrelay
Copy link
Contributor

analogrelay commented Mar 4, 2020

This is the discussion issue for aspnet/Announcements#408

ASP.NET Core currently includes three packages designed to integrate our components with Azure services. Specifically, the following three packages:

The Azure SDK team is introducing brand new packages that provide the same extensions using the latest version of the Azure SDK. These packages will be maintained by the Azure SDK team at the Azure/azure-sdk-for-net repository. Moving these packages over to the Azure SDK team will allow that team to update them as the SDKs themselves are updated, rather than being tied to the .NET Core schedule.

If you are using any of the packages listed above, we suggest replacing them with the new packages:

These new packages are supported on .NET Core 2.1 and 3.1 so you do not need to wait for 5.0 to update!

These are new packages that bring in a new version of the Azure SDK which includes breaking changes. The general usage patterns are the same as the existing packages, but some overloads and options may be different (in order to react to the changes to the underlying Azure SDK APIs).

The existing Microsoft. packages listed above will continue to be fully supported by the ASP.NET Core team for the lifetime of .NET Core 2.1 and 3.1. However, they will not be shipping in .NET 5. When upgrading your application to .NET 5, you will need to transition to the Azure. packages in order to be supported.

@juunas11
Copy link
Contributor

Just wanna comment that I made a quick Core 3.1 app that uses the 2 data protection packages and it was really easy to plug them in :)
Here's a link to that: https://github.com/juunas11/Joonasw.AzureDataProtection/blob/0880cb95d08c220ce7fb8d754192da7f0ebe24bf/Joonasw.AzureDataProtection/Startup.cs#L43

Plugged DefaultAzureCredential to both and everything works really nicely locally.
I'll probably write up a blog post on using these 👍

@TechWatching
Copy link

What will happened to Microsoft.AspNetCore.AzureKeyVault.HostingStartup that is automatically added to a csproj when using "Connected Services" in Visual Studio 2019 ?

@analogrelay
Copy link
Contributor Author

@TechWatching yep, we're working with that team to get a plan in place. For now it continues to use the legacy packages (which are still fully supported in .NET Core 2.1 and 3.1).

@tebeco
Copy link
Contributor

tebeco commented Jul 14, 2020

Hello ;)

Is that normal ?
I mean if it's supposed to be already working for 2.1 and 3.x it should probably not look like this right ?

image

@analogrelay
Copy link
Contributor Author

analogrelay commented Jul 15, 2020

Looks like it got renamed/changed since the original preview. If you expand that notice, it has the details.

image

@tebeco
Copy link
Contributor

tebeco commented Jul 15, 2020

@anurse
oO thanks a lot, I did not spotted that is was expandable, many thanks

Do you think it's possible to edit the links here for further lookup ?
#19570 (comment)

image

@analogrelay
Copy link
Contributor Author

Should be, yeah. I still have permission since I posted the issue but perhaps @Pilchie should have someone on the team double check things since I'm no longer on the ASP.NET team.

@Pilchie
Copy link
Member

Pilchie commented Jul 15, 2020

I'm following up.

@Pilchie
Copy link
Member

Pilchie commented Jul 15, 2020

Updated the announcement issue, and the first comment on this issue with the packages, and removed the text about them being preview versions.

@tebeco
Copy link
Contributor

tebeco commented Jul 16, 2020

thx a lot

@heaths
Copy link

heaths commented Aug 14, 2020

So all references will be updated to the new packages? Was Microsoft.AspNetCore.All removed then? It accounts for 15.2% of our daily downloads of Microsoft.Azure.KeyVault, which we'd like to get on Azure.Security.KeyVault.Secrets instead. I can only find commits that remove references to it, unless I missed actual code clean up to remove the package for .NET 5.

If newer versions of the older packages for < .NET 5.0 will be updated, would it be feasible to update them to reference the new packages? The Azure SDK team can work with .NET on this to make sure the code calling into the new client libraries continues to work.

/cc @AlexGhiondea @pakrym

@Pilchie
Copy link
Member

Pilchie commented Aug 14, 2020

Microsoft.AspNetCore.All hasn't existed since .NET Core 2.2.

We cannot update packages for < 5.0, because it would be a breaking change. That's the whole reason we made the new packages in the first place.

@ghost
Copy link

ghost commented Nov 12, 2020

Thank you for contacting us. Due to a lack of activity on this discussion issue we're closing it in an effort to keep our backlog clean. If you believe there is a concern related to the ASP.NET Core framework, which hasn't been addressed yet, please file a new issue.

This issue will be locked after 30 more days of inactivity. If you still wish to discuss this subject after then, please create a new issue!

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants