Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensionless files are not served by default #2438

Open
aspnet-hello opened this issue Jan 1, 2018 · 3 comments
Open

Extensionless files are not served by default #2438

aspnet-hello opened this issue Jan 1, 2018 · 3 comments
Labels
affected-few This issue impacts only small number of customers area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlesware enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-static-files severity-minor This label is used by an internal tool
Milestone

Comments

@aspnet-hello
Copy link

From @sebastienros on Tuesday, November 14, 2017 6:16:05 PM

Because it's missing an entry in the default IContentTypeProvider
Some files like acme-challenge (used by Let's Encrypt) or Apple application ids, don't use extensions.

I'd like to know if it could be reconsidered.

Copied from original issue: aspnet/StaticFiles#223

@aspnet-hello
Copy link
Author

From @Tratcher on Tuesday, November 14, 2017 9:38:07 PM

This acme-challenge spec?
https://github.com/ietf-wg-acme/acme/blob/0b172d509a725336633b9a76998e907a8e0002e3/draft-ietf-acme-acme.md#L1992
This doesn't look like static content, it looks like a dynamic challenge-response handshake.

Apple app ids look like they're domain name based, or am I missing something?
https://developer.apple.com/library/content/documentation/General/Conceptual/DevPedia-CocoaCore/AppID.html

@aspnet-hello
Copy link
Author

From @sebastienros on Wednesday, November 15, 2017 9:08:00 AM

This is the set of files I personally needed for Let's Encrypt, you'll notice they don't have extensions

image

Here is the documentation on how to configure Stripe with apple pay id (it's not apple application id, my bad)

image

I believe many developers would lose some time understanding why it doesn't work, or even not be able to update the app that easily as it needs a new deployment.

@aspnet-hello
Copy link
Author

From @sebastienros on Wednesday, November 15, 2017 9:42:27 AM

I can confirm that there is no other way to serve these file than setting ServeUnknownFileTypes and optionally DefaultContentType. Registering a custom IContentTypeProvider and adding "" or "." won't have any effect. So it's all or nothing in this case.

@muratg muratg added this to the Backlog milestone Mar 3, 2018
@JunTaoLuo JunTaoLuo added affected-few This issue impacts only small number of customers enhancement This issue represents an ask for new feature or an enhancement to an existing one severity-minor This label is used by an internal tool labels Nov 11, 2020 — with ASP.NET Core Issue Ranking
@amcasey amcasey added area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlesware and removed area-runtime labels Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected-few This issue impacts only small number of customers area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlesware enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-static-files severity-minor This label is used by an internal tool
Projects
None yet
Development

No branches or pull requests

5 participants