Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable Components tests that verifies browser logs #25803

Closed
JunTaoLuo opened this issue Sep 11, 2020 · 1 comment
Closed

Re-enable Components tests that verifies browser logs #25803

JunTaoLuo opened this issue Sep 11, 2020 · 1 comment
Assignees
@SteveSandersonMS
Labels
area-blazor Includes: Blazor, Razor Components area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Done This issue has been fixed test-failure
Projects
ASP.NET Core Blazor & MVC 5.0.x
Milestone
5.0.0

Comments

@JunTaoLuo
Copy link
Contributor

This issue tracks the work-item to re-enable tests that remain disabled as part of #25330. The problem is that due to the bug SeleniumHQ/selenium#8229 we are unable to retrieve browser logs. Our tests that verify browser logs have thus been disabled.

Possible resolutions:

  • Wait for Selenium bug to be fixed before the tests are re-enabled, in the meantime we will be missing test coverage
  • Lockdown an older version of Chrome to use in our CI environment
  • Only run these tests locally where we can more easily control the version of Chrome and Selenium used
@JunTaoLuo JunTaoLuo added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework area-blazor Includes: Blazor, Razor Components labels Sep 11, 2020
@mkArtakMSFT mkArtakMSFT added this to the Next sprint planning milestone Sep 14, 2020
@ghost
Copy link

ghost commented Sep 14, 2020

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We will evaluate the request when we are planning the work for the next milestone. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@SteveSandersonMS SteveSandersonMS self-assigned this Sep 21, 2020
@SteveSandersonMS SteveSandersonMS moved this from 5.0 GA to In progress in ASP.NET Core Blazor & MVC 5.0.x Oct 12, 2020
SteveSandersonMS added a commit that referenced this issue Oct 22, 2020
@SteveSandersonMS
Restore support for logs in E2E tests. Fixes #25803
b2255db
ASP.NET Core Blazor & MVC 5.0.x automation moved this from In progress to Done Oct 23, 2020
@ghost ghost added Done This issue has been fixed and removed Working labels Oct 23, 2020
SteveSandersonMS added a commit that referenced this issue Oct 23, 2020
@SteveSandersonMS
Fix E2E test use of logs (#27114)
2cc610c 
* Restore support for logs in E2E tests. Fixes #25803

* Revert earlier workaround

* Update message in assertion

* Remove redundant script references
@ghost ghost locked as resolved and limited conversation to collaborators Nov 22, 2020
wtgodbe pushed a commit that referenced this issue Feb 11, 2021
@SteveSandersonMS
Fix E2E test use of logs (#27114) (#27166)
5b4f300 
* Restore support for logs in E2E tests. Fixes #25803

* Revert earlier workaround

* Update message in assertion

* Remove redundant script references
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@SteveSandersonMS SteveSandersonMS

Labels
area-blazor Includes: Blazor, Razor Components area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Done This issue has been fixed test-failure
Projects
No open projects
ASP.NET Core Blazor & MVC 5.0.x
  
Done
Milestone
5.0.0
Development

No branches or pull requests
3 participants
@SteveSandersonMS @JunTaoLuo @mkArtakMSFT