Fix E2E test use of logs #27114
Merged
Fix E2E test use of logs #27114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pilchie
added
the
area-mvc
pranavkm
approved these changes
Oct 22, 2020
| @@ -342,5 +342,14 @@ private async Task<(IWebDriver browser, ILogs log)> CreateSauceBrowserAsync(stri | |||
|
|
|||
| throw new InvalidOperationException("Couldn't create a SauceLabs remote driver client."); | |||
| } | |||
|
|
|||
| // This is a workaround for https://github.com/SeleniumHQ/selenium/issues/8229 | |||
| private class RemoteWebDriverWithLogs : RemoteWebDriver, ISupportsLogs | |||
SteveSandersonMS
added a commit
that referenced
this pull request
Oct 23, 2020
* Restore support for logs in E2E tests. Fixes #25803 * Revert earlier workaround * Update message in assertion * Remove redundant script references
wtgodbe
pushed a commit
that referenced
this pull request
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores support for reading logs like before.