Fix E2E test use of logs (#27114) #27166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Restore support for logs in E2E tests. Fixes #25803 * Revert earlier workaround * Update message in assertion * Remove redundant script references
Pilchie
added
the
area-mvc
Member
Author
|
@mkArtakMSFT This is just porting a test fix from |
Member
Author
|
@mkArtakMSFT Ping on this. |
captainsafia
approved these changes
Nov 30, 2020
captainsafia
added
the
tell-mode
Member
|
@SteveSandersonMS branches are open for February, do you want me to merge this? |
Member
Author
|
@wtgodbe Yes, that would be great! Thanks. |
Member
|
@SteveSandersonMS well, now they are closed again 😆. We can get this merged for next month |
Member
Author
|
@wtgodbe Are we in a position to include this in 5.0.4? |
Member
Yep, branches are open until EOD today. Want me to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test-only change that ports the existing PR #27114 from
mastertorelease/5.0. If this is not meant to be done manually like this, please let me know.