Remove Newtonsoft.Json from the shared framework

[natemcmaster]

The following shared-framework libraries pull in Newtonsoft.Json:

• - Microsoft.AspNetCore.Mvc.ViewFeatures
• - Microsoft.Extensions.Configuration.Json
• - Microsoft.Extensions.DependencyModel
• - Microsoft.IdentityModel.JsonWebTokens
• - Microsoft.AspNetCore.SignalR.Protocols.Json
• - Microsoft.AspNetCore.Authentication.OAuth
• - Microsoft.Extensions.Logging.EventSource

These assemblies and dependencies need to be updated to remove their dependency on Newtonsoft.Json.

[natemcmaster]

Tracking external issues:

• https://github.com/dotnet/core-setup/issues/3311
• Remove dependency on Newtonsoft.Json from Config.Json extensions#568
• Replace the dependency on Newtonsoft.Json with new .NET Json APIs AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet#1060
• Remove Newtonsoft.Json dependency from EventSource logger extensions#1013

Internal changes needed:

• @Tratcher - update Microsoft.AspNetCore.Authentication.OAuth
• @rynowak @mkArtakMSFT - we need to update Microsoft.AspNetCore.Mvc.ViewFeatures to make sure it doesn't pull in Newtonsoft.Json.
• Update our dependency on IdentityModel.

[natemcmaster]

Also adding @mkArtakMSFT to help with MVC's dependency on Json.net and myself to coordinate with partners on getting Json.net removed.

[natemcmaster]

Pushing out to preview3. We are still blocked on https://github.com/dotnet/core-setup/issues/3311 and dotnet/extensions#568

[Tratcher]

Partially unblocked by dotnet/corefx#34485

[joshfree]

/cc @ahsonkhan and @steveharter who will have a porting-guide.md (soon) to assist with this

[muratg]

Adding @BrennanConroy for Microsoft.AspNetCore.SignalR.Protocols.Json

[BrennanConroy]

JsonDocument doesn't help us, we need the serializer and deserializer :)

[BrennanConroy]

Also, was there ever a discussion/decision for the netstandard issue?

[muratg]

@joshfree @ahsonkhan @steveharter?

[davidfowl]

Yea there’s a source version of the reader and writer for ns2.0

[ahsonkhan]

Also, was there ever a discussion/decision for the netstandard issue?

Yea there’s a source version of the reader and writer for ns2.0

https://dotnet.myget.org/feed/dotnet-core/package/nuget/Microsoft.Bcl.Json.Sources

It contains the JsonDocument as well.

For guidance on consuming the source pacakge, visit: https://aka.ms/json-source-package-guide.

[BrennanConroy]

JsonDocument is now available to our builds.

[natemcmaster]

Looks like DependencyModel has removed Json.Net, Oauth and Config.Json are in the works (#7105, dotnet/extensions#1028) and I believe SignalR is done (#6977). I think we'll be able to complete this for Preview 3.

[bradygaster]

Perhaps if scaffolding existed to add SignalR would be a good middle ground, but even that would have costs.

I'd prefer just litter all the templates with "opt-in" functionality for SignalR, which'd drop in what they need in Startup.cs and a sample Hub class. Yes, there's a cost, but I think we should start thinking about when to pay that cost. I'll set up another issue for us to use to discuss this idea, so we can re-focus this thread on the issue at hand.

[davidfowl]

A SignalR template would be fine tbh, we resisted it for long but it would be a useful starting point as there's lots of moving pieces

[BrennanConroy]

Added Microsoft.Extensions.Logging.EventSource to the list at the top of this issue

cc @pakrym

[Tratcher]

Microsoft.AspNetCore.Authentication.* are done.

[natemcmaster]

This did not make it into preview3 and is being pushed out to preview4.

[HaoK]

Config PR merged dotnet/extensions#1028

[pakrym]

Logging done dotnet/extensions#1227.

[BrennanConroy]

FYI need to update ResolveReferences.targets file after this is done
https://github.com/aspnet/AspNetCore/blob/17344cd37f0b43b28c93c58cba667e55bd680624/eng/targets/ResolveReferences.targets#L88

[mkArtak]

@pranavkm can you please confirm whether this is done already?

we need to update Microsoft.AspNetCore.Mvc.ViewFeatures to make sure it doesn't pull in Newtonsoft.Json.