Remove JsonPatch from the shared framework #6867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natemcmaster
added
the
breaking-change
pranavkm
approved these changes
Jan 19, 2019
There was a problem hiding this comment.
Package is already in the right section in artifacts.props: https://github.com/aspnet/AspNetCore/blob/master/build/artifacts.props#L56
davidfowl
approved these changes
Jan 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4260 and #3755
This dependency should have been removed when we did #5146, but it got missed. Per our design review, this was one of the assemblies we decided should be removed from the shared framework. Users can add this to their projects by adding a PackageReference.
cc @mkArtakMSFT @muratg we should do this for Preview 2 to front load as many breaking changes as we can.