-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on Newtonsoft.Json from Config.Json #568
Comments
cc @ajcvickers @HaoK. This is something we should do for 3.0. The sooner the better so we can provide corefx with feedback on the new Json APIs. |
@natemcmaster @DamianEdwards @Eilon @HaoK and I discussed this yesterday and we don't believe it is possible to implement under the current plan. Specifically, since Config is in Extensions, and Extensions must still target .netstandard2.0, and the new JSON APIs will not be available on .netstandard2.0, there's no way to use them. |
Should we get in a room to discuss? |
Yes, I think we should. |
Yup agreed. |
Due to some differences in the new json stack and Json.Net for back compat, we are going to add another package that continues to use Json.NET see: #1075 The main difference between the two is loss of support for single quotes: var json = @"{
'setting': {
'hello': 'a',
'bob': 'b',
'42': 'c',
'4':'d',
'10': 'e',
'1text': 'f',
} |
Added via #1028 |
cref dotnet/announcements#90
Let's remove our dependency on Newtonsoft.Json from the Json configuration provider and use System.Text.Json. This will unblock dotnet/aspnetcore#4260.
The text was updated successfully, but these errors were encountered: