Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on Newtonsoft.Json from Config.Json #568

Closed
natemcmaster opened this issue Nov 27, 2018 · 8 comments
Closed

Remove dependency on Newtonsoft.Json from Config.Json #568

natemcmaster opened this issue Nov 27, 2018 · 8 comments
Assignees

Comments

@natemcmaster
Copy link

cref dotnet/announcements#90

Let's remove our dependency on Newtonsoft.Json from the Json configuration provider and use System.Text.Json. This will unblock dotnet/aspnetcore#4260.

@natemcmaster
Copy link
Author

cc @ajcvickers @HaoK. This is something we should do for 3.0. The sooner the better so we can provide corefx with feedback on the new Json APIs.

@ajcvickers
Copy link
Member

ajcvickers commented Dec 15, 2018

@natemcmaster @DamianEdwards @Eilon

@HaoK and I discussed this yesterday and we don't believe it is possible to implement under the current plan. Specifically, since Config is in Extensions, and Extensions must still target .netstandard2.0, and the new JSON APIs will not be available on .netstandard2.0, there's no way to use them.

@Eilon
Copy link
Member

Eilon commented Dec 17, 2018

Should we get in a room to discuss?

@natemcmaster
Copy link
Author

Yes, I think we should.

@ajcvickers
Copy link
Member

@Eilon Yep. But I think the discussion is wider than just this. There are other packages where we are saying we want to both support new features and .NET Framework. /cc @divega

@Eilon
Copy link
Member

Eilon commented Dec 17, 2018

Yup agreed.

@HaoK
Copy link
Member

HaoK commented Feb 6, 2019

Due to some differences in the new json stack and Json.Net for back compat, we are going to add another package that continues to use Json.NET see: #1075

The main difference between the two is loss of support for single quotes:

            var json = @"{
                'setting': {
                    'hello': 'a',
                    'bob': 'b',
                    '42': 'c',
                    '4':'d',
                    '10': 'e',
                    '1text': 'f',
                }

@HaoK HaoK modified the milestones: 3.0.0-preview2, 3.0.0-preview4 Feb 28, 2019
@HaoK HaoK added the 3 - Done label Feb 28, 2019
@HaoK
Copy link
Member

HaoK commented Feb 28, 2019

Added via #1028

@HaoK HaoK closed this as completed Feb 28, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants