Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static web assets SDK support for multi targeting conventions #47885

Open
javiercn opened this issue Apr 25, 2023 · 3 comments
Open

Static web assets SDK support for multi targeting conventions #47885

javiercn opened this issue Apr 25, 2023 · 3 comments
Assignees
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-blazor-single-project Priority:1 Work that is critical for the release, but we could probably ship without

Comments

@javiercn
Copy link
Member

Update Static Web Assets to account for multitargeted projects.
The project needs to include the assets produced by the net8.0-browser TFM.
We need to handle the different TFM combinations here
We need to do work to support multi-targeting during build and publish.

For the conventions see https://learn.microsoft.com/en-us/dotnet/maui/platform-integration/configure-multi-targeting?view=net-maui-7.0

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Apr 25, 2023
@mkArtakMSFT mkArtakMSFT added the enhancement This issue represents an ask for new feature or an enhancement to an existing one label Apr 25, 2023
@mkArtakMSFT mkArtakMSFT added this to the .NET 8 Planning milestone Apr 25, 2023
@ghost
Copy link

ghost commented Apr 25, 2023

Thanks for contacting us.

We're moving this issue to the .NET 8 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@mkArtakMSFT mkArtakMSFT added the Priority:1 Work that is critical for the release, but we could probably ship without label Apr 25, 2023
@javiercn
Copy link
Member Author

javiercn commented Jun 21, 2023

Initial cut here

Missing gaps:

  • Conflict resolution for scoped css: We need to figure out what we do here. We don't want to embed the app bundle Project.styles.css. We want to keep platform specific styles (for example, if a component is defined inside the Browser folder) so we want to get the project bundle for it and merge it into the main app bundle in the embedding TFM.
  • Conflict resolution for JS modules: There's likely no conflict as long as we don't do any rename.
  • Conflict resolution for JS initializers: We need to pass in the initializers to the embedding TFM.
  • Service worker
  • Retrieve assets from embedded referenced projects: This is the case when the project is multitargeting and it has a project reference that is exclusive to the embedded target. For example, a project A that multitargets net8.0;net8.0-browser and there is a project reference to project B that only applies to net8.0-browser.
  • Retrieve package assets from embedded referenced packages: This is the case when the project is multitargeting and it has a package reference that is exclusive to the embedded target. For example, a project A that multitargets net8.0;net8.0-browser and there is a package reference to package B that only applies to net8.0-browser.

@javiercn
Copy link
Member Author

#49074

@mkArtakMSFT mkArtakMSFT modified the milestones: 8.0-preview7, 8.0-rc2 Jul 3, 2023
@mkArtakMSFT mkArtakMSFT modified the milestones: 8.0-rc2, .NET 9 Planning Aug 21, 2023
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-blazor-single-project Priority:1 Work that is critical for the release, but we could probably ship without
Projects
None yet
Development

No branches or pull requests

4 participants