Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional test assets do not re-publish in VS inner loop #9693

Open
Tratcher opened this issue Apr 23, 2019 · 4 comments
Open

Functional test assets do not re-publish in VS inner loop #9693

Tratcher opened this issue Apr 23, 2019 · 4 comments
Labels
affected-very-few This issue impacts very few customers area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions severity-nice-to-have This label is used by an internal tool task
Milestone
Backlog

Comments

@Tratcher
Copy link
Member

A recent build change modified functional test assets like src/Servers/testassets/ServerComparison.TestSites to publish as part of the build. This is working well for CI, but it doesn't work for inner-loop development.

Repro:

  1. run src/Servers/build.cmd
  2. Open src/Servers/FunctionalTests.sln in VS.
  3. Run the tests
  4. Edit the test site such that the test should fail and run the tests again. Your changes will not be applied.

This makes debugging and updating the test assets difficult in the inner dev loop.

@jkotalik
@analogrelay analogrelay added this to the 3.0.0-preview8 milestone May 21, 2019
@jkotalik jkotalik self-assigned this Jul 2, 2019
@jkotalik
Copy link
Contributor

jkotalik commented Jul 9, 2019

With this, I'm going to also make this work for MusicStore as those are currently disabled.

@jkotalik jkotalik mentioned this issue Jul 9, 2019
Open
@analogrelay analogrelay modified the milestones: 3.0.0-preview8, Backlog Jul 9, 2019
@jkotalik
Copy link
Contributor

@BrennanConroy @Tratcher I'm not 100% certain here, but after switching the build bitness to x64 in VS, did you see published assets working?

@jkotalik jkotalik added affected-very-few This issue impacts very few customers severity-nice-to-have This label is used by an internal tool labels Nov 13, 2020 — with ASP.NET Core Issue Ranking
@Tratcher
Copy link
Member Author

I don't remember. Why would changing the bitness affect this when the test sites are pre-published?

@jkotalik
Copy link
Contributor

When it's on Any CPU, it fails to build the native binaries, which I believe then causes it to fail to build.

@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affected-very-few This issue impacts very few customers area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions severity-nice-to-have This label is used by an internal tool task
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@analogrelay @Tratcher @jkotalik @amcasey @mkArtakMSFT