[release/5.0] Update dependencies from dotnet/efcore dotnet/runtime #28087

dotnet-maestro · 2020-11-23T17:35:46Z

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

Subscription: 2ccac658-6e68-4e98-ebd5-08d85e711a64
Build: 20201125.16
Date Produced: 11/26/2020 3:40 AM
Commit: b02e13abab3d6f499751af2ad1ae6333fb4e633d
Branch: refs/heads/release/5.0

Updates:
- System.IO.Pipelines: from 5.0.0 to 5.0.1
- Microsoft.NETCore.App.Internal: from 5.0.1-servicing.20570.12 to 5.0.1-servicing.20575.16
- Microsoft.Extensions.DependencyInjection: from 5.0.0 to 5.0.1
- Microsoft.NETCore.App.Runtime.win-x64: from 5.0.1 to 5.0.1
- Microsoft.NETCore.BrowserDebugHost.Transport: from 5.0.1-servicing.20570.12 to 5.0.1-servicing.20575.16
- System.Security.Cryptography.Pkcs: from 5.0.0 to 5.0.1

From https://github.com/dotnet/efcore

Subscription: 5a5466f0-17ae-442c-2f05-08d85e5f2673
Build: 20201125.6
Date Produced: 11/26/2020 12:22 AM
Commit: e08026a638e684e6d3eabbd65702251e8c0febea
Branch: refs/heads/release/5.0

Updates:
- Microsoft.EntityFrameworkCore.Tools: from 5.0.1 to 5.0.1
- dotnet-ef: from 5.0.1 to 5.0.1
- Microsoft.EntityFrameworkCore: from 5.0.1 to 5.0.1
- Microsoft.EntityFrameworkCore.Design: from 5.0.1 to 5.0.1
- Microsoft.EntityFrameworkCore.InMemory: from 5.0.1 to 5.0.1
- Microsoft.EntityFrameworkCore.Relational: from 5.0.1 to 5.0.1
- Microsoft.EntityFrameworkCore.Sqlite: from 5.0.1 to 5.0.1
- Microsoft.EntityFrameworkCore.SqlServer: from 5.0.1 to 5.0.1

…1122.4 Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport From Version 5.0.1-servicing.20570.12 -> To Version 5.0.1-servicing.20572.4

ghost

Auto-approving dependency update.

…123.5 Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Design , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.SqlServer From Version 5.0.1 -> To Version 5.0.1

…1124.5 System.IO.Pipelines , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport From Version 5.0.0 -> To Version 5.0.1

…a7c-c6c2dcd90d64

…1124.8 System.IO.Pipelines , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport From Version 5.0.0 -> To Version 5.0.1

…124.5 Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Design , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.SqlServer From Version 5.0.1 -> To Version 5.0.1

…1124.11 System.IO.Pipelines , System.Security.Cryptography.Pkcs , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport From Version 5.0.1 -> To Version 5.0.1

…1124.14 System.IO.Pipelines , System.Security.Cryptography.Pkcs , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport From Version 5.0.1 -> To Version 5.0.1

…1125.2 System.IO.Pipelines , System.Security.Cryptography.Pkcs , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport From Version 5.0.1 -> To Version 5.0.1

…125.2 Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Design , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.SqlServer From Version 5.0.1 -> To Version 5.0.1

…1125.9 System.IO.Pipelines , Microsoft.NETCore.App.Internal , Microsoft.Extensions.DependencyInjection , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , System.Security.Cryptography.Pkcs From Version 5.0.0 -> To Version 5.0.1

pranavkm · 2020-11-25T22:16:41Z

src/Framework/test/SharedFxTests.cs

@@ -175,6 +175,15 @@ public void SharedFrameworkAssembliesHaveExpectedAssemblyVersions()
                var reader = peReader.GetMetadataReader(MetadataReaderOptions.Default);
                var assemblyDefinition = reader.GetAssemblyDefinition();

+                if (assemblyDefinition.GetAssemblyName().Name is


@JunTaoLuo when you return, could you have a look at this change? Some of these runtime versions have been updated. It's not super clear if that's problematic (I would think not?)

pranavkm · 2020-11-25T22:43:39Z

I tried debugging the build failure for a bit but I'm not 100% sure what a resolution would look like. The shared runtime gets a version of M.E.DependencyInjection from the microsoft.extensions.internal.transport package which wasn't updated as part of the most recent change. The rest of ASP.NET Core references it from the M.E.DependencyInjection nuget package. This mismatch results in a MSBuild warning.

@JunTaoLuo could you look in to this?

…125.6 Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Design , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.SqlServer From Version 5.0.1 -> To Version 5.0.1

…1125.12 System.IO.Pipelines , Microsoft.NETCore.App.Internal , Microsoft.Extensions.DependencyInjection , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , System.Security.Cryptography.Pkcs From Version 5.0.0 -> To Version 5.0.1

…1125.16 System.IO.Pipelines , Microsoft.NETCore.App.Internal , Microsoft.Extensions.DependencyInjection , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , System.Security.Cryptography.Pkcs From Version 5.0.0 -> To Version 5.0.1

dougbu · 2020-11-26T20:23:30Z

@pranavkm @ericstj @Pilchie the apparent issue here is likely due to assembly version changes in servicing, combined with the assemblies previously in dotnet/extensions releasing independently. dotnet/aspnetcore definitely does not "expect" the second.

Background: Microsoft.AspNetCore.App.Runtime.csproj uses reference resolution to determine the transitive closure of all assemblies required in the Microsoft.AspNetCore.App shared framework. It does some tricks to avoid compilation-only references and to exclude assemblies already available in the Microsoft.NETCore.App shared framework. The first part of that isn't working completely because eng/targets/ResolveReferences.targets adds a compilation-only reference to Microsoft.Extensions.Internal.Transport.nupkg.

Rather than adding more direct dependencies, suggest removing that implicit reference. I'll try that but am unlikely to pay attention…

- Microsoft.AspNetCore.App.Runtime project does not expect compilation-only references

- slight change to 49cc13c workaround

- avoid problems with e.g. System.Extensions.DependencyInjection in 5.0.1

…ng (#25851)" - dotnet/runtime assembly versions are unexpectedly changing in servicing This reverts commit bfc1ec6.

- assemblies with non-0.0 versions end up in Microsoft.AspNetCore.App - future-proofs these tests because more dotnet/runtime versions may change

dougbu · 2020-11-30T00:43:13Z

FYI primary non-Windows error is

/datadisks/disk1/workspace/_work/1/s/.dotnet/sdk/5.0.100/Microsoft.Common.CurrentVersion.targets(2123,5): error MSB3106: Assembly strong name "/datadisks/disk1/workspace/_work/1/s/.packages/system.io.pipelines/5.0.0/ref/netcoreapp2.0/System.IO.Pipelines.dll" is either a path which could not be found or it is a full assembly name which is badly formed. If it is a full assembly name it may contain characters that need to be escaped with backslash(\). Those characters are Equals(=), Comma(,), Quote("), Apostrophe('), Backslash(\). [/datadisks/disk1/workspace/_work/1/s/src/Http/Http.Features/src/Microsoft.AspNetCore.Http.Features.csproj]

Likely restored %(RTMVersion) handling is working only on Windows for some reason…

- need the RTM-versioned packages on all platforms - we only target `net472` on Windows

Update dependencies from https://github.com/dotnet/runtime build 2020…

fb76f71

…1122.4 Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport From Version 5.0.1-servicing.20570.12 -> To Version 5.0.1-servicing.20572.4

dotnet-maestro bot requested a review from dougbu as a code owner November 23, 2020 17:35

ghost added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼 labels Nov 23, 2020

ghost approved these changes Nov 23, 2020

View reviewed changes

ghost added the tell-mode Indicates a PR which is being merged during tell-mode label Nov 23, 2020

dotnet-maestro bot changed the title ~~[release/5.0] Update dependencies from dotnet/runtime~~ [release/5.0] Update dependencies from dotnet/runtime dotnet/efcore Nov 24, 2020

Update dependencies from https://github.com/dotnet/runtime build 2020…

3bac5cb

…1124.5 System.IO.Pipelines , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport From Version 5.0.0 -> To Version 5.0.1

dotnet-maestro bot changed the title ~~[release/5.0] Update dependencies from dotnet/runtime dotnet/efcore~~ [release/5.0] Update dependencies from dotnet/efcore dotnet/runtime Nov 24, 2020

pranavkm and others added 7 commits November 25, 2020 10:57

Merge branch 'release/5.0' into darc-release/5.0-d4478e43-6d04-47a1-8…

d797588

…a7c-c6c2dcd90d64

Update dependencies from https://github.com/dotnet/runtime build 2020…

5114a09

…1124.8 System.IO.Pipelines , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport From Version 5.0.0 -> To Version 5.0.1

dotnet-maestro bot changed the title ~~[release/5.0] Update dependencies from dotnet/efcore dotnet/runtime~~ [release/5.0] Update dependencies from dotnet/runtime dotnet/efcore Nov 25, 2020

dotnet-maestro bot changed the title ~~[release/5.0] Update dependencies from dotnet/runtime dotnet/efcore~~ [release/5.0] Update dependencies from dotnet/efcore dotnet/runtime Nov 25, 2020

Tweak tests

8c7af26

dotnet-maestro bot requested review from SteveSandersonMS and a team as code owners November 25, 2020 22:13

pranavkm reviewed Nov 25, 2020

View reviewed changes

dotnet-maestro bot changed the title ~~[release/5.0] Update dependencies from dotnet/efcore dotnet/runtime~~ [release/5.0] Update dependencies from dotnet/runtime dotnet/efcore Nov 26, 2020

dotnet-maestro bot changed the title ~~[release/5.0] Update dependencies from dotnet/runtime dotnet/efcore~~ [release/5.0] Update dependencies from dotnet/efcore dotnet/runtime Nov 26, 2020

dougbu added 5 commits November 26, 2020 12:32

Remove Extensions.Internal.Transport from Runtime

49cc13c

- Microsoft.AspNetCore.App.Runtime project does not expect compilation-only references

!fixup! Rearrange a Condition

bfd5b5d

- slight change to 49cc13c workaround

Do not compile against assemblies with newer assembly versions

b16bd62

- avoid problems with e.g. System.Extensions.DependencyInjection in 5.0.1

Revert "Remove package version pinning for ref/ assemblies in servici…

fc338b6

…ng (#25851)" - dotnet/runtime assembly versions are unexpectedly changing in servicing This reverts commit bfc1ec6.

Update SharedFxTests to handle dotnet/runtime version changes

346fb29

- assemblies with non-0.0 versions end up in Microsoft.AspNetCore.App - future-proofs these tests because more dotnet/runtime versions may change

!fixup! Revert of bfc1ec6 messed up RepoTasks

f38c5b2

- need the RTM-versioned packages on all platforms - we only target `net472` on Windows

dotnet-maestro bot merged commit d0f0901 into release/5.0 Nov 30, 2020

dotnet-maestro bot deleted the darc-release/5.0-d4478e43-6d04-47a1-8a7c-c6c2dcd90d64 branch November 30, 2020 03:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release/5.0] Update dependencies from dotnet/efcore dotnet/runtime #28087

[release/5.0] Update dependencies from dotnet/efcore dotnet/runtime #28087

dotnet-maestro bot commented Nov 23, 2020 •

edited

Loading

ghost left a comment

pranavkm Nov 25, 2020

pranavkm commented Nov 25, 2020

dougbu commented Nov 26, 2020

dougbu commented Nov 30, 2020

[release/5.0] Update dependencies from dotnet/efcore dotnet/runtime #28087

[release/5.0] Update dependencies from dotnet/efcore dotnet/runtime #28087

Conversation

dotnet-maestro bot commented Nov 23, 2020 • edited Loading

From https://github.com/dotnet/runtime

From https://github.com/dotnet/efcore

ghost left a comment

Choose a reason for hiding this comment

pranavkm Nov 25, 2020

Choose a reason for hiding this comment

pranavkm commented Nov 25, 2020

dougbu commented Nov 26, 2020

dougbu commented Nov 30, 2020

dotnet-maestro bot commented Nov 23, 2020 •

edited

Loading