Skip to content
This repository has been archived by the owner on Jan 11, 2024. It is now read-only.

Buildtools has an outdated build process #195

Closed
mellinoe opened this issue Jul 16, 2015 · 7 comments
Closed

Buildtools has an outdated build process #195

mellinoe opened this issue Jul 16, 2015 · 7 comments

Comments

@mellinoe
Copy link

Currently, we're using a really old version of buildtools, and the .NET Core Xunit assemblies we build in this repo are building against very old versions of our NuGet packages (very different from the latest packages), and are still using packages.config files. We should update these to be in line with corefx.

@ericstj
Copy link
Member

ericstj commented Jul 20, 2015

I'd like to fix this with https://github.com/dotnet/corefx/issues/2427 instead

@ericstj ericstj closed this as completed Jul 20, 2015
@mellinoe
Copy link
Author

Did you mean to close this? I'm fine with making the same improvement to both repos if that's what we intend to do.

@weshaggard
Copy link
Member

Given @JeremyKuhne reverted your update @mellinoe we should reopen this issue. I think @ericstj is referring to a more general update away from dnx and less of you intended with this issue which is to update the buildtools repo itself to use the latest buildtools.

@mellinoe
Copy link
Author

Sounds good to me. I think it makes sense to get this repo on the latest buildtools, because then when we make improvements to corefx's build process, we can just apply them here as well, instead of having to jump straight from this repo's old build process.

@mellinoe
Copy link
Author

#205 merged and the official build went through fine. This particular issue (being on an old version of buildtools) should be resolved now.

@weshaggard
Copy link
Member

@mellinoe Have you tried the new build against CoreFX to ensure everything still works as expected?

@mellinoe
Copy link
Author

CoreFx is already on the new tools and hasn't hit any issues so far. There aren't really any functional changes here, other than possibly the fact that we are using new packages as opposed to the months-old ones.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants