Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename coreclr\src\mscorlib directory to coreclr\src\System.Private.CoreLib #10294

Closed
danmoseley opened this issue May 7, 2018 · 3 comments
Closed
Assignees

Comments

@danmoseley
Copy link
Member

See #7394. This will reduce confusion: as the work continues to unify more and more code in the two corelibs, it makes sense for the directory name to reflect this. Also, it reflects the rename we did from mscorlib for 1.0.

@maryamariyan you'll just need to do this and find everything that breaks. (Not just in the repo - eg., the mirror)

@danmoseley danmoseley changed the title coreclr\src\mscorlib to coreclr\src\System.Private.CoreLib Rename coreclr\src\mscorlib directory to coreclr\src\System.Private.CoreLib May 7, 2018
maryamariyan referenced this issue in maryamariyan/coreclr May 8, 2018
jkotas referenced this issue in dotnet/coreclr May 9, 2018
* diff from just renaming folder mscorlib to System.Private.CoreLib

* Updating build.proj to reflect name change

Fixes: #17905
@ViktorHofer
Copy link
Member

Now the history view inside Github doesn't show any changes older than the renamed folder commit. I'm not very happy about that :/

@maryamariyan
Copy link
Member

@ViktorHofer I use sourcetree to navigate around this. With sourcetree I add small diffs into the file to have the file show up in working directory as changed. Then can right click on the file to log it and trace back to older commits by checking out its parents.

@danmoseley
Copy link
Member Author

@ViktorHofer just edit the URL, this restarts it at the rename (616976 is the first commit after the rename)
https://github.com/dotnet/coreclr/commits/master?after=616976119f02491c1cf89de29451b1cf285928a9+0&path%5B%5D=src&path%5B%5D=mscorlib

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants