-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename coreclr\src\mscorlib directory to coreclr\src\System.Private.CoreLib #10294
Comments
* diff from just renaming folder mscorlib to System.Private.CoreLib * Updating build.proj to reflect name change Fixes: #17905
Now the history view inside Github doesn't show any changes older than the renamed folder commit. I'm not very happy about that :/ |
@ViktorHofer I use sourcetree to navigate around this. With sourcetree I add small diffs into the file to have the file show up in working directory as changed. Then can right click on the file to log it and trace back to older commits by checking out its parents. |
@ViktorHofer just edit the URL, this restarts it at the rename (616976 is the first commit after the rename) |
See #7394. This will reduce confusion: as the work continues to unify more and more code in the two corelibs, it makes sense for the directory name to reflect this. Also, it reflects the rename we did from mscorlib for 1.0.
@maryamariyan you'll just need to do this and find everything that breaks. (Not just in the repo - eg., the mirror)
The text was updated successfully, but these errors were encountered: