Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review disabled features in expression interpreter code #19107

Open
bartdesmet opened this issue Oct 26, 2016 · 2 comments
Open

Review disabled features in expression interpreter code #19107

bartdesmet opened this issue Oct 26, 2016 · 2 comments
Labels
area-System.Linq.Expressions enhancement Product code improvement that does NOT require public API changes/additions help wanted [up-for-grabs] Good issue for external contributors
Milestone
Future

Comments

@bartdesmet
Copy link
Contributor

We have the following #if symbols sprinkled across the code but never enabled:

  • FEATURE_COMPILE_TO_METHODBUILDER
  • FEATURE_PDB_GENERATOR
  • FEATURE_DLG_INVOKE
  • FEATURE_FAST_CREATE
  • FEATURE_THREAD_ABORT
  • FEATURE_MAKE_RUN_METHODS
  • FEATURE_STACK_TRACES
  • NO_FEATURE_STATIC_DELEGATE

Some may be worth enabling again given the addition of some APIs in the latest .NET Standard build flavors; others may be remnants of early DLR work and could be deemed dead code that can be removed.

CC @VSadov
@JonHanna
Copy link
Contributor

JonHanna commented Nov 8, 2016

#17137 is related in that it's disabled, but I'm not sure it should be.

@VSadov
Copy link
Member

VSadov commented Nov 29, 2016

Need to understand what each of these enable and the state of completeness.

Those that are useful, should be enabled (perhaps log separate issues for those).
Unnecessary ones (unfinished experiments, no longer relevant code, missing underlying APIs should be removed)

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 23, 2020
@cston cston mentioned this issue Jul 6, 2020
Closed
@cston cston removed the untriaged New issue has not been triaged by the area owner label Jul 6, 2020
@cston cston mentioned this issue Jul 6, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-System.Linq.Expressions enhancement Product code improvement that does NOT require public API changes/additions help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Milestone
Future
Development

No branches or pull requests
6 participants
@JonHanna @maryamariyan @bartdesmet @VSadov @msftgits @cston