Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-evaluate various #define symbols in System.Linq.Expressions #15549

Closed
bartdesmet opened this issue Oct 23, 2015 · 2 comments
Closed

Re-evaluate various #define symbols in System.Linq.Expressions #15549

bartdesmet opened this issue Oct 23, 2015 · 2 comments
Labels
area-System.Linq.Expressions enhancement Product code improvement that does NOT require public API changes/additions help wanted [up-for-grabs] Good issue for external contributors
Milestone
Future

Comments

@bartdesmet
Copy link
Contributor

The following symbols are used in the code but are never set in corefx:

  • FEATURE_DLG_INVOKE
  • FEATURE_FAST_CREATE
  • FEATURE_MAKE_RUN_METHODS
  • FEATURE_THREAD_ABORT
  • FEATURE_STACK_TRACES
  • NO_FEATURE_STATIC_DELEGATE

We should re-evaluate whether those are useful to enable in some build flavors e.g. to improve performance of the interpreter.
@VSadov VSadov removed their assignment Nov 29, 2016
@VSadov
Copy link
Member

VSadov commented Nov 29, 2016

next step would be identifying what these symbols were doing (supposedly more efficient implementations when something is available) and figure whether we should fix/enable it on CoreFX or just remove.

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 23, 2020
@cston cston removed the untriaged New issue has not been triaged by the area owner label Jul 6, 2020
@cston
Copy link
Member

cston commented Jul 6, 2020

Closing as duplicate of #19107.

@cston cston closed this as completed Jul 6, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Linq.Expressions enhancement Product code improvement that does NOT require public API changes/additions help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Milestone
Future
Development

No branches or pull requests
5 participants
@maryamariyan @bartdesmet @VSadov @msftgits @cston