This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Merge changes from TFS #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bProxy because in some cases it is null and I've not found a reason when it is actually ever needed. Also update our internal targets so they now download Nuget.exe again instead of using a checked in version. [tfs-changeset: 1416207]
|
@weshaggard This seems to undo the change from #38. Is this what we really want to be doing? |
|
Thanks for the pointer @ellismg I was trying to figure out why it was added. The reason I've removed it is because DefaultWebProxy is null in some cases and causes a NullReferenceException. For now let the mirror merge but I will change the code to allow it if it isn't null to re-enable the firewall scenario. |
|
Sounds good to me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.