Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build script to use default web proxy to download remote files. #22

Closed
wants to merge 1 commit into from

Conversation

PatrickMcDonald
Copy link
Contributor

No description provided.

@dnfclas
Copy link

dnfclas commented May 20, 2015

Hi @PatrickMcDonald, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@roncain
Copy link
Contributor

roncain commented May 20, 2015

Thanks for the suggestion. We're looking at it now.

@iamjasonp
Copy link
Member

Thanks @PatrickMcDonald!

If you're interested, similar fixes probably need to be made to the dotnet/corefx and dotnet/coreclr repos.

@PatrickMcDonald
Copy link
Contributor Author

dotnet/corefx#38 is already done, I'll have a look at dotnet/coreclr.

@PatrickMcDonald
Copy link
Contributor Author

It seems the corefx change was reverted with dotnet/corefx#788, I wasn't aware of that. See dotnet/corefx#963

@iamjasonp
Copy link
Member

Ahh, I was looking for why I didn't see corefx#38 in master, and was grovelling through the commits for the build.proj.

We synced up the build scripts and proj files between dotnet/wcf and dotnet/corefx a few days before our initial commit, so our build scripts should be reasonably similar. Once dotnet/corefx#963 gets fixed, that change should come over here too.

@PatrickMcDonald
Copy link
Contributor Author

Good stuff, I think the change should be relatively simple, I'll have a look there.

@iamjasonp
Copy link
Member

Awesome - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants