Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Update corefxlab license to match corefx #2459

Merged
merged 4 commits into from
Sep 4, 2018

Conversation

GrabYourPitchforks
Copy link
Member

These were changed:

  • The header at the top of each .cs source file.
  • The headers generated by .tt files.
  • Any copyright information (as XML comments) embedded in .csproj files.
  • The LICENSE file.

These were not changed:

@@ -3,8 +3,9 @@
// See the LICENSE file in the project root for more information.


// Copyright (c) Microsoft. All rights reserved.
// Licensed under the MIT license. See LICENSE file in the project root for full license information.
// Licensed to the .NET Foundation under one or more agreements.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This text is duplicate. We should remove it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - I'll update the regex to fix this.

@@ -3,8 +3,9 @@
// See the LICENSE file in the project root for more information.


// Copyright (c) Microsoft. All rights reserved.
// Licensed under the MIT license. See LICENSE file in the project root for full license information.
// Licensed to the .NET Foundation under one or more agreements.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, and other places under System.Text.Primitives.

Copy link
Member

@ahsonkhan ahsonkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM.

@safern
Copy link
Member

safern commented Aug 31, 2018

Thanks @GrabYourPitchforks 😄

Remove whitespace before headers
Copy link
Member

@terrajobst terrajobst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1,6 +1,7 @@
#
# Copyright (c) .NET Foundation and contributors. All rights reserved.
# Licensed under the MIT license. See LICENSE file in the project root for full license information.
# Licensed to the .NET Foundation under one or more agreements.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was borrowed from https://github.com/dotnet/cli/blob/master/scripts/obtain/dotnet-install.ps1, so I am not sure about the license here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted.

@@ -1,6 +1,7 @@
#!/usr/bin/env bash
# Copyright (c) .NET Foundation and contributors. All rights reserved.
# Licensed under the MIT license. See LICENSE file in the project root for full license information.
# Licensed to the .NET Foundation under one or more agreements.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you are making the changes here, can you please add the license header to the other scripts?
https://github.com/dotnet/corefxlab/blob/master/scripts/build.ps1
https://github.com/dotnet/corefxlab/blob/master/scripts/package.ps1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per @terrajobst's offline comments we'll just revert all the .ps1 / .cmd / .sh changes. Good eye though. :)

@GrabYourPitchforks GrabYourPitchforks merged commit 8cd063a into dotnet:master Sep 4, 2018
@GrabYourPitchforks GrabYourPitchforks deleted the license branch October 6, 2018 21:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants