-
Notifications
You must be signed in to change notification settings - Fork 347
Update corefxlab license to match corefx #2459
Conversation
@@ -3,8 +3,9 @@ | |||
// See the LICENSE file in the project root for more information. | |||
|
|||
|
|||
// Copyright (c) Microsoft. All rights reserved. | |||
// Licensed under the MIT license. See LICENSE file in the project root for full license information. | |||
// Licensed to the .NET Foundation under one or more agreements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This text is duplicate. We should remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch - I'll update the regex to fix this.
@@ -3,8 +3,9 @@ | |||
// See the LICENSE file in the project root for more information. | |||
|
|||
|
|||
// Copyright (c) Microsoft. All rights reserved. | |||
// Licensed under the MIT license. See LICENSE file in the project root for full license information. | |||
// Licensed to the .NET Foundation under one or more agreements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, and other places under System.Text.Primitives.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, LGTM.
Thanks @GrabYourPitchforks 😄 |
Remove whitespace before headers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
scripts/install-dotnet.ps1
Outdated
@@ -1,6 +1,7 @@ | |||
# | |||
# Copyright (c) .NET Foundation and contributors. All rights reserved. | |||
# Licensed under the MIT license. See LICENSE file in the project root for full license information. | |||
# Licensed to the .NET Foundation under one or more agreements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was borrowed from https://github.com/dotnet/cli/blob/master/scripts/obtain/dotnet-install.ps1, so I am not sure about the license here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted.
scripts/install-dotnet.sh
Outdated
@@ -1,6 +1,7 @@ | |||
#!/usr/bin/env bash | |||
# Copyright (c) .NET Foundation and contributors. All rights reserved. | |||
# Licensed under the MIT license. See LICENSE file in the project root for full license information. | |||
# Licensed to the .NET Foundation under one or more agreements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you are making the changes here, can you please add the license header to the other scripts?
https://github.com/dotnet/corefxlab/blob/master/scripts/build.ps1
https://github.com/dotnet/corefxlab/blob/master/scripts/package.ps1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per @terrajobst's offline comments we'll just revert all the .ps1 / .cmd / .sh changes. Good eye though. :)
These were changed:
LICENSE
file.These were not changed:
<copyright>
element in .csproj files, as they're baked into DLLs.corefxlab/src/System.Reflection.Metadata.Cil/Visitor/CilToStringVisitor.cs
Line 55 in 29d7aa0