Skip to content
This repository has been archived by the owner on Nov 1, 2020. It is now read-only.

Remove encoding workaround #213

Closed
MichalStrehovsky opened this issue Nov 6, 2015 · 4 comments
Closed

Remove encoding workaround #213

MichalStrehovsky opened this issue Nov 6, 2015 · 4 comments
Assignees
@MichalStrehovsky
Labels
TypeSystem
Milestone
February 2016

Comments

@MichalStrehovsky
Copy link
Member

\src\System.Private.CoreLib\src\System\Environment.EnvironmentVariables.Unix.cs has a workaround to return null for LANG environment variable. This is to prevent System.Console from taking complicated code paths that we don't support yet.

The required feature is either interface calls or constrained calls (don't remember which one...).
@MichalStrehovsky MichalStrehovsky self-assigned this Nov 18, 2015
@gkhanna79 gkhanna79 added this to the February milestone Dec 14, 2015
@jkotas jkotas changed the title Remove LANG workaround Remove encoding workaround Dec 29, 2015
@jkotas
Copy link
Member

jkotas commented Dec 29, 2015

This workaround was moved to src\System.Private.CoreLib\src\System\Text\Encoding.cs

MichalStrehovsky added a commit to MichalStrehovsky/corert that referenced this issue Feb 12, 2016
@MichalStrehovsky
Remove Encoding workaround
4c108d6 
This was needed either because of constrained calls or interface calls.
We now have both. Let's exercise those features.

Fixes dotnet#213.
@MichalStrehovsky MichalStrehovsky mentioned this issue Feb 12, 2016
Closed
@justinvp justinvp mentioned this issue Aug 25, 2016
Merged
@MichalStrehovsky
Copy link
Member Author

Fixed by #1732.

@MichalStrehovsky
Copy link
Member Author

Only 50% fixed :)

@jkotas jkotas mentioned this issue Sep 16, 2016
Closed
@jkotas jkotas mentioned this issue Oct 3, 2016
Merged
@MichalStrehovsky
Copy link
Member Author

Fixed by #1971.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MichalStrehovsky MichalStrehovsky

Labels
TypeSystem
Projects
None yet
Milestone
February 2016
Development

No branches or pull requests
3 participants
@jkotas @gkhanna79 @MichalStrehovsky