This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Split TypeLoadException throw helper into two #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The optional messageArg parameter causes a request for a null string token when building the TypeSystemThrowingIL helper if one of the TypeLoadException constructors is called using the default null value for messageArg. Split the constructors in `TypeSystemException` to ensure the base exception args array only contains the arguments passed in. This requires a new ThrowHelper which takes one fewer parameters, along with a new `CreateTypeLoadException` helper with the same signature.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optional messageArg parameter causes a request for a null string
token when building the TypeSystemThrowingIL helper if one of the
TypeLoadException constructors is called using the default null value
for messageArg.
Split the constructors in
TypeSystemExceptionto ensure the baseexception args array only contains the arguments passed in. This
requires a new ThrowHelper which takes one fewer parameters, along with
a new
CreateTypeLoadExceptionhelper with the same signature.