This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanup in CoreRT's TimeZoneInfo implementation:
The
CachedData
locking is currently inconsistent. Some code is using a privateLock
object withLockHolder.Hold
, while other code is locking against theCachedData
instance (viaMonitor.Enter/Exit
). This change removes the privateLock
object and just locks against theCachedData
instance throughout, which is consistent with the CoreCLR implementation.TimeZoneInfoComparer
is being used in two places in CoreRT to sort the list of system time zones, whereas it's only used in one place in CoreCLR. This change refactors the code to have a shared implementation ofGetSystemTimeZones
in CoreRT that handles the sorting in one place, allowing a singleComparison<T>
lambda to be used, which matches the CoreCLR implementation. Now the single sharedGetSystemTimeZones
implementation calls a private staticPopulateAllSystemTimeZones
method, which has separate implementations for Win32/WinRT/Unix. This addresses porting Remove private TimeZoneInfoComparer coreclr#8512.The WinRT implementation of
FindSystemTimeZoneById
was accessing the cached data without any locking. Added locking.cc: @tarekgh, @jkotas
Fixes #2388