Commits on Dec 24, 2016

1. TimeZoneInfo Cleanup …

   Some cleanup in CoreRT's TimeZoneInfo implementation:
   
   - The CachedData locking is currently inconsistent. Some code is using a
   private Lock object with LockHolder.Hold, while other code is locking
   against the CachedData instance. This change removes the private Lock
   object and just locks against the CachedData instance throughout, which
   is consistent with the CoreCLR implementation.
   
   - TimeZoneInfoComparer is being used in two places in CoreRT to sort the
   list of system time zones, whereas it's only used in one place in
   CoreCLR. This change refactors the code to have a shared implementation
   of GetSystemTimeZones in CoreRT that handles the sorting in one place,
   allowing a single Comparison<T> lambda to be used, which matches the
   CoreCLR implementation. Now there is a single shared GetSystemTimeZones
   implementation which calls a private static PopulateAllSystemTimeZones
   method, which is implemented separately for Win32/WinRT/Unix.
   
   - The WinRT implementation of FindSystemTimeZoneById was accessing the
   cached data without any locking. Added locking.

   

   justinvp committed Dec 24, 2016
   Configuration menu

   • View commit details
   • Copy full SHA for 785504c
   • Browse repository at this point

   Copy the full SHA

   785504c View commit details

   Browse the repository at this point in the history