Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't recommend BinaryFormatter #1551

Closed
gewarren opened this issue Dec 30, 2022 · 2 comments · Fixed by #1924
Closed

Don't recommend BinaryFormatter #1551

gewarren opened this issue Dec 30, 2022 · 2 comments · Fixed by #1924
Labels
doc-bug Problem with the content; needs to be fixed [org][type][category] dotnet-framework/svc in-pr okr-health Content-health KR: Concerns article defects/freshness or build warnings. okr-quality Pri1 High priority, do before Pri2 and Pri3 📌 seQUESTered Label to indicate an item has been imported. wpf/subsvc

Comments

@gewarren
Copy link
Contributor

gewarren commented Dec 30, 2022 •
edited by sequestor bot
Loading

Type of issue

Outdated article

Description

BinaryFormatter is unsafe to use. This article shouldn't recommend using it and should add a caution block similar to https://learn.microsoft.com/en-us/dotnet/standard/serialization/binary-serialization.

Related to dotnet/docs#32568.

Page URL

https://learn.microsoft.com/en-us/dotnet/desktop/wpf/advanced/application-startup-time?view=netframeworkdesktop-4.8

Content source URL

https://github.com/dotnet/docs-desktop/blob/main/dotnet-desktop-guide/framework/wpf/advanced/application-startup-time.md

Document Version Independent Id

c7e42d2e-6ad7-4d68-d778-879698cac362

Article author

@adegeo

Associated WorkItem - 330109
@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label Dec 30, 2022
@gewarren gewarren mentioned this issue Dec 30, 2022
Closed
11 tasks
@adegeo adegeo added Pri1 High priority, do before Pri2 and Pri3 doc-bug Problem with the content; needs to be fixed [org][type][category] and removed Pri2 Medium priority labels Jan 5, 2023
@dotnet-bot dotnet-bot removed the ⌚ Not Triaged Not triaged label Jan 5, 2023
@dotnet-policy-service dotnet-policy-service bot added the okr-health Content-health KR: Concerns article defects/freshness or build warnings. label Jan 19, 2024
@adegeo adegeo added the 🗺️ reQUEST Trigger label to import an issue into Quest label Oct 11, 2024
@dotnetrepoman dotnetrepoman bot added 🗺️ mapQUEST Only used as a way to mark an issue as updated. RepoMan should instantly remove it. and removed 🗺️ mapQUEST Only used as a way to mark an issue as updated. RepoMan should instantly remove it. labels Oct 11, 2024
@sequestor sequestor bot added 📌 seQUESTered Label to indicate an item has been imported. and removed 🗺️ reQUEST Trigger label to import an issue into Quest labels Oct 22, 2024
@eriawan
Copy link
Member

eriawan commented Nov 3, 2024

@gewarren

I'm quite curious about this issue. Now that BinaryFormatter is deleted in .NET 9.0, should we also remove the description section about BinaryFormatter in the Application Startup time documentation in the original issue?

@gewarren
Copy link
Contributor Author

gewarren commented Nov 4, 2024

@jeffhandley Not sure if you were aware of this section, but we should either revise it or remove it with high priority, I would think.

@jeffhandley jeffhandley mentioned this issue Nov 12, 2024
Merged
@jeffhandley jeffhandley mentioned this issue Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc-bug Problem with the content; needs to be fixed [org][type][category] dotnet-framework/svc in-pr okr-health Content-health KR: Concerns article defects/freshness or build warnings. okr-quality Pri1 High priority, do before Pri2 and Pri3 📌 seQUESTered Label to indicate an item has been imported. wpf/subsvc
Projects
dotnet/docs November 2024 sprint
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update startup time guidance to not recommend BinaryFormatter dotnet/docs-desktop
4 participants
@eriawan @dotnet-bot @gewarren @adegeo